Merge pull request #56 from spowelljr/addStartArgs

Add start-args field

Author: medyagh

.github/workflows/test.yml

@@ -7,52 +7,48 @@ on: # rebuild any PRs and main branch changes
     branches:
       - master
       - 'releases/*'
-
 jobs:
   build: # make sure build/ci work properly
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c
-    - run: |
-        npm install
-        npm run all
+      - uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c
+      - run: |
+          npm install
+          npm run all
   test: # make sure the action works on a clean machine without building
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c
-    - uses: ./
-      with:
-        addons: ingress
-
-    # Test that nginx ingress has been enabled
-    - run: |
-        minikube addons list | grep 'ingress ' | grep enabled
+      - uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c
+      - uses: ./
+        with:
+          addons: ingress
+      # Test that nginx ingress has been enabled
+      - run: |
+          minikube addons list | grep 'ingress ' | grep enabled
   test-extraOptions:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c
       - uses: ./
         with:
           extra-config: 'kubelet.max-pods=10'
-
       # Test that minikube max-pods extraConfig has been set
       - run: |
           cat ~/.minikube/profiles/minikube/config.json | jq '.KubernetesConfig.ExtraOptions[0].Key' | grep max-pods
   test-insecure-registry:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8
+      - uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c
       - uses: ./
         with:
           insecure-registry: '192.168.0.0/16'
-
       # Test that minikube max-pods extraConfig has been set
       - run: |
           minikube ssh cat /lib/systemd/system/docker.service | grep 192.168.0.0/16
   test-featureGatesOptions:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@755da8c3cf115ac066823e79a1e1788f8940201b
+      - uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c
       - uses: ./
         with:
           feature-gates: 'ValidatingAdmissionPolicy=true'

README.md

@@ -6,9 +6,9 @@
 ## Basic Usage
 ```
     steps:
-    - name: start minikube
-      id: minikube
-      uses: medyagh/setup-minikube@latest
+      - name: start minikube
+        id: minikube
+        uses: medyagh/setup-minikube@latest
 
 ```
 
@@ -221,6 +221,15 @@ By default setup-minikube caches the ISO, kicbase, and preload using GitHub Acti
   </pre>
 </details>
 
+<details>
+  <summary>start-args (optional)</summary>
+  <pre>
+    - default: ''
+    - value: Any flags you would regularly pass into minikube via CLI
+    - example: --delete-on-failure --subnet 192.168.50.0
+  </pre>
+</details>
+
 ## Example 1: 
 #### Start Kubernetes on pull request
 
@@ -233,12 +242,12 @@ jobs:
     runs-on: ubuntu-latest
     name: job1
     steps:
-    - name: start minikube
-      id: minikube
-      uses: medyagh/setup-minikube@latest
-    # now you can run kubectl to see the pods in the cluster
-    - name: kubectl
-      run: kubectl get pods -A
+      - name: start minikube
+        id: minikube
+        uses: medyagh/setup-minikube@latest
+      # now you can run kubectl to see the pods in the cluster
+      - name: kubectl
+        run: kubectl get pods -A
 ```
 
 ## Example 2
@@ -253,25 +262,28 @@ jobs:
     runs-on: ubuntu-latest
     name: job1
     steps:
-    - name: start minikube
-      uses: medyagh/setup-minikube@latest
-      id: minikube
-      with:
-        minikube-version: 1.24.0
-        driver: docker
-        container-runtime: containerd
-        kubernetes-version: v1.22.3
-        cpus: 4
-        memory: 4000m
-        cni: bridge
-        addons: registry,ingress
-        extra-config: 'kubelet.max-pods=10'
-        feature-gates: 'DownwardAPIHugePages=true'
-        mount-path: '/Users/user1/test-files:/testdata'
-        insecure-registry: localhost:5000,10.0.0.0/24
-    # now you can run kubectl to see the pods in the cluster
-    - name: kubectl
-      run: kubectl get pods -A
+      - name: start minikube
+        uses: medyagh/setup-minikube@latest
+        id: minikube
+        with:
+          cache: false
+          minikube-version: 1.24.0
+          driver: docker
+          container-runtime: containerd
+          kubernetes-version: v1.22.3
+          cpus: 4
+          memory: 4000m
+          cni: bridge
+          addons: registry,ingress
+          extra-config: 'kubelet.max-pods=10'
+          feature-gates: 'DownwardAPIHugePages=true'
+          mount-path: '/Users/user1/test-files:/testdata'
+          wait: false
+          insecure-registry: 'localhost:5000,10.0.0.0/24'
+          start-args: '--delete-on-failure --subnet 192.168.50.0'
+      # now you can run kubectl to see the pods in the cluster
+      - name: kubectl
+        run: kubectl get pods -A
 ```
 
 ## Example 3:
@@ -286,28 +298,28 @@ jobs:
     runs-on: ubuntu-latest
     name: build discover and deploy
     steps:
-    - uses: actions/checkout@v2
-    - name: Start minikube
-      uses: medyagh/setup-minikube@latest
+      - uses: actions/checkout@v2
+      - name: Start minikube
+        uses: medyagh/setup-minikube@latest
       # now you can run kubectl to see the pods in the cluster
-    - name: Try the cluster!
-      run: kubectl get pods -A
-    - name: Build image
-      run: |
-        export SHELL=/bin/bash
-        eval $(minikube -p minikube docker-env)
-        make build-image
-        echo -n "verifying images:"
-        docker images
-    - name: Deploy to minikube
-      run:
-        kubectl apply -f deploy/deploy-minikube.yaml
-    - name: Test service URLs
-      run: |
-        minikube service list
-        minikube service discover --url
-        echo -n "------------------opening the service------------------"
-        curl $(minikube service discover --url)/version
+      - name: Try the cluster!
+        run: kubectl get pods -A
+      - name: Build image
+        run: |
+          export SHELL=/bin/bash
+          eval $(minikube -p minikube docker-env)
+          make build-image
+          echo -n "verifying images:"
+          docker images
+      - name: Deploy to minikube
+        run: |
+          kubectl apply -f deploy/deploy-minikube.yaml
+      - name: Test service URLs
+        run: |
+          minikube service list
+          minikube service discover --url
+          echo -n "------------------opening the service------------------"
+          curl $(minikube service discover --url)/version
 ```
 ## Real World: 
 #### Add your own repo here:

action.yml

@@ -69,6 +69,10 @@ inputs:
     description: 'Enable insecure communication with the given registries'
     required: false
     default: ''
+  start-args:
+    description: 'Any flags you would regularly pass into minikube via CLI'
+    required: false
+    default: ''
 runs:
   using: 'node16'
   main: 'dist/index.js'