Skip to content

Commit a292511

Browse files
committed
Add conditional #pragma for clang diagnostics
Signed-off-by: Michael Jackson <mike.jackson@bluequartz.net>
1 parent 6f73a64 commit a292511

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

Wrapping/Python/Pybind11/CodeScraper/PythonBindingClass.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -801,6 +801,8 @@ QString PythonBindingClass::generateFooterCode()
801801

802802
// Close up the Anonymous namespace
803803
out << "} /* End anonymous namespace */\n\n";
804-
out << "#pragma clang diagnostic pop\n\n";
804+
out << "#if !defined(_MSC_VER)\n";
805+
out << "#pragma clang diagnostic pop\n";
806+
out << "#endif\n";
805807
return code;
806808
}

Wrapping/Python/Pybind11/Templates/Pybind11TopMatter.in.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
#pragma once
22

3+
#if !defined(_MSC_VER)
34
#pragma clang diagnostic push
45
#pragma clang diagnostic ignored "-Wreturn-std-move"
6+
#endif
57

68
// clang-format off
79
/* =============================================================================

0 commit comments

Comments
 (0)