Skip to content

Add EventGrid diagnostic settings#4258

Merged
tamirkamara merged 5 commits intomainfrom
tamirkamara/event-grid-diag
Jan 8, 2025
Merged

Add EventGrid diagnostic settings#4258
tamirkamara merged 5 commits intomainfrom
tamirkamara/event-grid-diag

Conversation

@tamirkamara
Copy link
Copy Markdown
Collaborator

What is being addressed

In some situation the airlock might stop processing requests and it's hard to understand why.

How is this addressed

  • Add EventGrid logs so that we can understand if failures occur

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 7, 2025

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit beef7ed.

♻️ This comment has been updated with latest results.

@tamirkamara
Copy link
Copy Markdown
Collaborator Author

/test-extended

@tamirkamara tamirkamara marked this pull request as ready for review January 7, 2025 20:18
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 7, 2025

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12658663990 (with refid 28e46b66)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Copy Markdown
Collaborator Author

/test-extended

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 8, 2025

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12665297912 (with refid 28e46b66)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara enabled auto-merge (squash) January 8, 2025 06:29
Copy link
Copy Markdown
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One comment/question.

@marrobi marrobi requested a review from Copilot January 8, 2025 08:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (7)
  • core/terraform/airlock/airlock_processor.tf: Language not supported
  • core/terraform/airlock/data.tf: Language not supported
  • core/terraform/airlock/eventgrid_topics.tf: Language not supported
  • core/terraform/airlock/identity.tf: Language not supported
  • core/terraform/airlock/locals.tf: Language not supported
  • core/terraform/deploy.sh: Language not supported
  • core/version.txt: Language not supported

Copy link
Copy Markdown
Collaborator

@yuvalyaron yuvalyaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tamirkamara tamirkamara merged commit 3704002 into main Jan 8, 2025
@tamirkamara tamirkamara deleted the tamirkamara/event-grid-diag branch January 8, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants