Fix Behavior Related to namedCaptureGroups

graphemecluster · graphemecluster · commit 75a1e909cf9d · 2024-05-28T10:57:10.000+08:00
diff --git a/src/compiler/scanner.ts b/src/compiler/scanner.ts
@@ -2490,7 +2490,8 @@ export function createScanner(languageVersion: ScriptTarget, skipTrivia: boolean
                     inCharacterClass = false;
                 }
                 else if (
-                    ch === CharacterCodes.openParen
+                    !inCharacterClass
+                    && ch === CharacterCodes.openParen
                     && charCodeChecked(pos + 1) === CharacterCodes.question
                     && charCodeChecked(pos + 2) === CharacterCodes.lessThan
                     && charCodeChecked(pos + 3) !== CharacterCodes.equals
@@ -2877,7 +2878,7 @@ export function createScanner(languageVersion: ScriptTarget, skipTrivia: boolean
                         scanGroupName(/*isReference*/ true);
                         scanExpectedChar(CharacterCodes.greaterThan);
                     }
-                    else if (namedCaptureGroups) {
+                    else if (anyUnicodeModeOrNonAnnexB || namedCaptureGroups) {
                         error(Diagnostics.k_must_be_followed_by_a_capturing_group_name_enclosed_in_angle_brackets, pos - 2, 2);
                     }
                     break;

Original file line number	Diff line number	Diff line change
`@@ -2490,7 +2490,8 @@ export function createScanner(languageVersion: ScriptTarget, skipTrivia: boolean`
`2490`	`2490`	`inCharacterClass = false;`
`2491`	`2491`	`}`
`2492`	`2492`	`else if (`
`2493`		`- ch === CharacterCodes.openParen`
	`2493`	`+ !inCharacterClass`
	`2494`	`+ && ch === CharacterCodes.openParen`
`2494`	`2495`	`&& charCodeChecked(pos + 1) === CharacterCodes.question`
`2495`	`2496`	`&& charCodeChecked(pos + 2) === CharacterCodes.lessThan`
`2496`	`2497`	`&& charCodeChecked(pos + 3) !== CharacterCodes.equals`
`@@ -2877,7 +2878,7 @@ export function createScanner(languageVersion: ScriptTarget, skipTrivia: boolean`
`2877`	`2878`	`scanGroupName(/isReference/ true);`
`2878`	`2879`	`scanExpectedChar(CharacterCodes.greaterThan);`
`2879`	`2880`	`}`
`2880`		`- else if (namedCaptureGroups) {`
	`2881`	`+ else if (anyUnicodeModeOrNonAnnexB \|\| namedCaptureGroups) {`
`2881`	`2882`	`error(Diagnostics.k_must_be_followed_by_a_capturing_group_name_enclosed_in_angle_brackets, pos - 2, 2);`
`2882`	`2883`	`}`
`2883`	`2884`	`break;`