From 1d82b65d4db298611121877e646ee4d88738ae7a Mon Sep 17 00:00:00 2001 From: Karthik Nadig Date: Tue, 4 Jun 2024 17:36:42 -0700 Subject: [PATCH 01/24] Add `conda` and `pyenv` --- .github/workflows/pr-check.yml | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml index 7d86ccac..3dc0a9c3 100644 --- a/.github/workflows/pr-check.yml +++ b/.github/workflows/pr-check.yml @@ -48,6 +48,26 @@ jobs: - name: Cargo Fetch run: cargo fetch + - name: Add Conda to PATH + run: | + if [-eq "${{ matrix.os }}" "windows-latest"}]; then + echo "PATH=$PATH;$CONDA" >> "$GITHUB_ENV" + else + echo "PATH=$PATH:$CONDA" >> "$GITHUB_ENV" + fi + + - name: Install pyenv + if: startsWith( matrix.os, 'windows') + run: | + choco install pyenv-win -y + pyenv install 3.12.3 3.11.9 3.10.14 3.9.19 3.8.19 + + - name: Install pyenv + if: startsWith( matrix.os, 'ubuntu') || startsWith( matrix.os, 'macos') + run: | + curl https://pyenv.run | bash + pyenv install 3.12.3 3.11.9 3.10.14 3.9.19 3.8.19 + - name: Run Tests run: cargo test --frozen --all-features From 24fa226a66d1979e94899b23a7cebac89f978b53 Mon Sep 17 00:00:00 2001 From: Karthik Nadig Date: Tue, 4 Jun 2024 17:42:26 -0700 Subject: [PATCH 02/24] Fix pyenv --- .github/workflows/pr-check.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml index 3dc0a9c3..e524c7eb 100644 --- a/.github/workflows/pr-check.yml +++ b/.github/workflows/pr-check.yml @@ -50,7 +50,7 @@ jobs: - name: Add Conda to PATH run: | - if [-eq "${{ matrix.os }}" "windows-latest"}]; then + if [-eq "${{ matrix.os }}" "windows-latest"]; then echo "PATH=$PATH;$CONDA" >> "$GITHUB_ENV" else echo "PATH=$PATH:$CONDA" >> "$GITHUB_ENV" @@ -61,12 +61,15 @@ jobs: run: | choco install pyenv-win -y pyenv install 3.12.3 3.11.9 3.10.14 3.9.19 3.8.19 + - name: Install pyenv if: startsWith( matrix.os, 'ubuntu') || startsWith( matrix.os, 'macos') run: | curl https://pyenv.run | bash - pyenv install 3.12.3 3.11.9 3.10.14 3.9.19 3.8.19 + echo PYENV_ROOT="$HOME/.pyenv" >> $GITHUB_ENV + echo PATH="$HOME/.pyenv/bin:$PATH" >> $GITHUB_ENV + ~/.pyenv/bin/pyenv install 3.12.3 3.11.9 3.10.14 3.9.19 3.8.19 - name: Run Tests run: cargo test --frozen --all-features From 5d0511e6e617ae77b1f4f571472b9a2ff8a141c3 Mon Sep 17 00:00:00 2001 From: Karthik Nadig Date: Tue, 4 Jun 2024 17:45:41 -0700 Subject: [PATCH 03/24] Fix conda path --- .github/workflows/pr-check.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml index e524c7eb..f5a333d8 100644 --- a/.github/workflows/pr-check.yml +++ b/.github/workflows/pr-check.yml @@ -49,12 +49,12 @@ jobs: run: cargo fetch - name: Add Conda to PATH - run: | - if [-eq "${{ matrix.os }}" "windows-latest"]; then - echo "PATH=$PATH;$CONDA" >> "$GITHUB_ENV" - else - echo "PATH=$PATH:$CONDA" >> "$GITHUB_ENV" - fi + if: startsWith( matrix.os, 'windows') + run: echo "PATH=$PATH;$CONDA" >> "$GITHUB_ENV" + + - name: Add Conda to PATH + if: startsWith( matrix.os, 'ubuntu') || startsWith( matrix.os, 'macos') + run: echo "PATH=$PATH:$CONDA" >> "$GITHUB_ENV" - name: Install pyenv if: startsWith( matrix.os, 'windows') From 381ad19233385feb6fcf8c553ccad4655c733de7 Mon Sep 17 00:00:00 2001 From: Karthik Nadig Date: Tue, 4 Jun 2024 17:53:12 -0700 Subject: [PATCH 04/24] Add conda and pyenv version check --- .github/workflows/pr-check.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml index f5a333d8..257b1838 100644 --- a/.github/workflows/pr-check.yml +++ b/.github/workflows/pr-check.yml @@ -61,7 +61,6 @@ jobs: run: | choco install pyenv-win -y pyenv install 3.12.3 3.11.9 3.10.14 3.9.19 3.8.19 - - name: Install pyenv if: startsWith( matrix.os, 'ubuntu') || startsWith( matrix.os, 'macos') @@ -71,6 +70,11 @@ jobs: echo PATH="$HOME/.pyenv/bin:$PATH" >> $GITHUB_ENV ~/.pyenv/bin/pyenv install 3.12.3 3.11.9 3.10.14 3.9.19 3.8.19 + - name: Check Conda and Pyenv version + run: | + conda --version + pyenv --version + - name: Run Tests run: cargo test --frozen --all-features From d059d002cf17b78d6b5651ee828ef43f42302627 Mon Sep 17 00:00:00 2001 From: Karthik Nadig Date: Tue, 4 Jun 2024 18:03:33 -0700 Subject: [PATCH 05/24] More pyenv fixes --- .github/workflows/pr-check.yml | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml index 257b1838..876ffa93 100644 --- a/.github/workflows/pr-check.yml +++ b/.github/workflows/pr-check.yml @@ -50,17 +50,22 @@ jobs: - name: Add Conda to PATH if: startsWith( matrix.os, 'windows') - run: echo "PATH=$PATH;$CONDA" >> "$GITHUB_ENV" + run: echo "PATH=%PATH%;%CONDA%" >> "$GITHUB_ENV" - name: Add Conda to PATH if: startsWith( matrix.os, 'ubuntu') || startsWith( matrix.os, 'macos') run: echo "PATH=$PATH:$CONDA" >> "$GITHUB_ENV" + - name: Check Conda version + run: conda --version + - name: Install pyenv if: startsWith( matrix.os, 'windows') run: | choco install pyenv-win -y - pyenv install 3.12.3 3.11.9 3.10.14 3.9.19 3.8.19 + echo PATH=%PATH%;%USERPROFILE%\.pyenv\pyenv-win\bin >> $GITHUB_ENV + echo PATH=%PATH%;%USERPROFILE%\.pyenv\pyenv-win\shims >> $GITHUB_ENV + %USERPROFILE%\.pyenv\pyenv-win\bin\pyenv install 3.12.3 3.11.9 3.10.14 3.9.19 3.8.19 - name: Install pyenv if: startsWith( matrix.os, 'ubuntu') || startsWith( matrix.os, 'macos') @@ -70,10 +75,8 @@ jobs: echo PATH="$HOME/.pyenv/bin:$PATH" >> $GITHUB_ENV ~/.pyenv/bin/pyenv install 3.12.3 3.11.9 3.10.14 3.9.19 3.8.19 - - name: Check Conda and Pyenv version - run: | - conda --version - pyenv --version + - name: Check Pyenv version + run: pyenv --version - name: Run Tests run: cargo test --frozen --all-features From a07bfd5dc4d39b09ec520e59b35a823b6b598e6e Mon Sep 17 00:00:00 2001 From: Karthik Nadig Date: Tue, 4 Jun 2024 18:06:26 -0700 Subject: [PATCH 06/24] use conda info all --- .github/workflows/pr-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml index 876ffa93..29dbfa4d 100644 --- a/.github/workflows/pr-check.yml +++ b/.github/workflows/pr-check.yml @@ -57,7 +57,7 @@ jobs: run: echo "PATH=$PATH:$CONDA" >> "$GITHUB_ENV" - name: Check Conda version - run: conda --version + run: conda info --all - name: Install pyenv if: startsWith( matrix.os, 'windows') From 63f8402da137537305e5ce1b6419cf93fcccf794 Mon Sep 17 00:00:00 2001 From: Karthik Nadig Date: Tue, 4 Jun 2024 18:14:06 -0700 Subject: [PATCH 07/24] Fix conda/bin --- .github/workflows/pr-check.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml index 29dbfa4d..18b8a7a1 100644 --- a/.github/workflows/pr-check.yml +++ b/.github/workflows/pr-check.yml @@ -50,11 +50,11 @@ jobs: - name: Add Conda to PATH if: startsWith( matrix.os, 'windows') - run: echo "PATH=%PATH%;%CONDA%" >> "$GITHUB_ENV" + run: echo "PATH=%PATH%;%CONDA%/bin" >> "$GITHUB_ENV" - name: Add Conda to PATH if: startsWith( matrix.os, 'ubuntu') || startsWith( matrix.os, 'macos') - run: echo "PATH=$PATH:$CONDA" >> "$GITHUB_ENV" + run: echo "PATH=$PATH:$CONDA/bin" >> "$GITHUB_ENV" - name: Check Conda version run: conda info --all From 3d278c087ef7e24e4b714931670a17a4752ac790 Mon Sep 17 00:00:00 2001 From: Karthik Nadig Date: Tue, 4 Jun 2024 18:18:41 -0700 Subject: [PATCH 08/24] Debug conda --- .github/workflows/pr-check.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml index 18b8a7a1..0dabccf0 100644 --- a/.github/workflows/pr-check.yml +++ b/.github/workflows/pr-check.yml @@ -50,11 +50,15 @@ jobs: - name: Add Conda to PATH if: startsWith( matrix.os, 'windows') - run: echo "PATH=%PATH%;%CONDA%/bin" >> "$GITHUB_ENV" + run: | + echo %CONDA% + echo "PATH=%PATH%;%CONDA%/bin" >> $GITHUB_ENV - name: Add Conda to PATH if: startsWith( matrix.os, 'ubuntu') || startsWith( matrix.os, 'macos') - run: echo "PATH=$PATH:$CONDA/bin" >> "$GITHUB_ENV" + run: | + echo $CONDA + echo "PATH=$PATH:$CONDA/bin" >> $GITHUB_ENV - name: Check Conda version run: conda info --all From 31134803f07b294990f1bf3a73071f1b76f62d90 Mon Sep 17 00:00:00 2001 From: Karthik Nadig Date: Tue, 4 Jun 2024 18:24:34 -0700 Subject: [PATCH 09/24] try another format --- .github/workflows/pr-check.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml index 0dabccf0..4a923226 100644 --- a/.github/workflows/pr-check.yml +++ b/.github/workflows/pr-check.yml @@ -51,14 +51,16 @@ jobs: - name: Add Conda to PATH if: startsWith( matrix.os, 'windows') run: | - echo %CONDA% - echo "PATH=%PATH%;%CONDA%/bin" >> $GITHUB_ENV + echo $CONDA + echo "PATH=$PATH;$CONDA/bin" >> $GITHUB_ENV + shell: bash - name: Add Conda to PATH if: startsWith( matrix.os, 'ubuntu') || startsWith( matrix.os, 'macos') run: | echo $CONDA echo "PATH=$PATH:$CONDA/bin" >> $GITHUB_ENV + shell: bash - name: Check Conda version run: conda info --all From d446e0b393cc94bdaa5264931b3f894de3389f58 Mon Sep 17 00:00:00 2001 From: Karthik Nadig Date: Tue, 4 Jun 2024 18:28:43 -0700 Subject: [PATCH 10/24] more fixes --- .github/workflows/pr-check.yml | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml index 4a923226..7d8dd5bf 100644 --- a/.github/workflows/pr-check.yml +++ b/.github/workflows/pr-check.yml @@ -49,19 +49,12 @@ jobs: run: cargo fetch - name: Add Conda to PATH - if: startsWith( matrix.os, 'windows') run: | echo $CONDA + ls $CONDA echo "PATH=$PATH;$CONDA/bin" >> $GITHUB_ENV shell: bash - - name: Add Conda to PATH - if: startsWith( matrix.os, 'ubuntu') || startsWith( matrix.os, 'macos') - run: | - echo $CONDA - echo "PATH=$PATH:$CONDA/bin" >> $GITHUB_ENV - shell: bash - - name: Check Conda version run: conda info --all @@ -69,9 +62,10 @@ jobs: if: startsWith( matrix.os, 'windows') run: | choco install pyenv-win -y - echo PATH=%PATH%;%USERPROFILE%\.pyenv\pyenv-win\bin >> $GITHUB_ENV - echo PATH=%PATH%;%USERPROFILE%\.pyenv\pyenv-win\shims >> $GITHUB_ENV - %USERPROFILE%\.pyenv\pyenv-win\bin\pyenv install 3.12.3 3.11.9 3.10.14 3.9.19 3.8.19 + echo PATH=$PATH;$USERPROFILE/.pyenv/pyenv-win/bin >> $GITHUB_ENV + echo PATH=$PATH;$USERPROFILE/.pyenv/pyenv-win/shims >> $GITHUB_ENV + $USERPROFILE/.pyenv/pyenv-win/bin/pyenv install 3.12.3 3.11.9 3.10.14 3.9.19 3.8.19 + shell: bash - name: Install pyenv if: startsWith( matrix.os, 'ubuntu') || startsWith( matrix.os, 'macos') From 94fcf15b276d54510a88b1cbc1f19ef8708f9128 Mon Sep 17 00:00:00 2001 From: Karthik Nadig Date: Tue, 4 Jun 2024 18:31:26 -0700 Subject: [PATCH 11/24] check conda bin --- .github/workflows/pr-check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml index 7d8dd5bf..997e4196 100644 --- a/.github/workflows/pr-check.yml +++ b/.github/workflows/pr-check.yml @@ -51,7 +51,7 @@ jobs: - name: Add Conda to PATH run: | echo $CONDA - ls $CONDA + ls $CONDA/condabin echo "PATH=$PATH;$CONDA/bin" >> $GITHUB_ENV shell: bash From cca2f5fa45ba42ae8d9f880ec4b103118be5db80 Mon Sep 17 00:00:00 2001 From: Karthik Nadig Date: Tue, 4 Jun 2024 18:36:19 -0700 Subject: [PATCH 12/24] Install conda on mac --- .github/workflows/pr-check.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml index 997e4196..fc453cff 100644 --- a/.github/workflows/pr-check.yml +++ b/.github/workflows/pr-check.yml @@ -49,12 +49,20 @@ jobs: run: cargo fetch - name: Add Conda to PATH + if: startsWith( matrix.os, 'windows') || startsWith( matrix.os, 'ubuntu') run: | echo $CONDA ls $CONDA/condabin echo "PATH=$PATH;$CONDA/bin" >> $GITHUB_ENV shell: bash + - name: Install Conda + if: startsWith( matrix.os, 'macos') + run: | + curl -o ~/miniconda.sh https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh + bash ~/miniconda.sh -b -p ~/miniconda + echo PATH=$PATH:$HOME/miniconda/bin >> $GITHUB_ENV + - name: Check Conda version run: conda info --all From dc6305c90f98544d2ac5abffa00fa202f8391197 Mon Sep 17 00:00:00 2001 From: Karthik Nadig Date: Tue, 4 Jun 2024 18:40:40 -0700 Subject: [PATCH 13/24] Tweak conda setup --- .github/workflows/pr-check.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml index fc453cff..580b49ad 100644 --- a/.github/workflows/pr-check.yml +++ b/.github/workflows/pr-check.yml @@ -52,11 +52,12 @@ jobs: if: startsWith( matrix.os, 'windows') || startsWith( matrix.os, 'ubuntu') run: | echo $CONDA + echo "condabin contents:" ls $CONDA/condabin - echo "PATH=$PATH;$CONDA/bin" >> $GITHUB_ENV + echo "PATH=$PATH;$CONDA/condabin" >> $GITHUB_ENV shell: bash - - name: Install Conda + - name: Install Conda + add to PATH if: startsWith( matrix.os, 'macos') run: | curl -o ~/miniconda.sh https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh From 9e81df3d78eb5bbbd3befa55428ccd0bcff8d044 Mon Sep 17 00:00:00 2001 From: Karthik Nadig Date: Tue, 4 Jun 2024 19:33:38 -0700 Subject: [PATCH 14/24] Add more env managers --- .github/workflows/pr-check.yml | 53 +++++++++++++++++++++++++--------- 1 file changed, 40 insertions(+), 13 deletions(-) diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml index 580b49ad..e590bfc1 100644 --- a/.github/workflows/pr-check.yml +++ b/.github/workflows/pr-check.yml @@ -50,11 +50,7 @@ jobs: - name: Add Conda to PATH if: startsWith( matrix.os, 'windows') || startsWith( matrix.os, 'ubuntu') - run: | - echo $CONDA - echo "condabin contents:" - ls $CONDA/condabin - echo "PATH=$PATH;$CONDA/condabin" >> $GITHUB_ENV + run: echo "PATH=$PATH;$CONDA/condabin" >> $GITHUB_ENV shell: bash - name: Install Conda + add to PATH @@ -62,31 +58,62 @@ jobs: run: | curl -o ~/miniconda.sh https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh bash ~/miniconda.sh -b -p ~/miniconda - echo PATH=$PATH:$HOME/miniconda/bin >> $GITHUB_ENV + echo "PATH=$PATH:$HOME/miniconda/bin" >> $GITHUB_ENV + echo "CONDA=$HOME/miniconda" >> $GITHUB_ENV + shell: bash - name: Check Conda version run: conda info --all + - name: Install pipenv + run: pip install --user pipenv + shell: bash + + - name: Check pipenv version + run: pipenv --version + + - name: Install virtualnvwrapper + if: startsWith( matrix.os, 'ubuntu') || startsWith( matrix.os, 'macos') + run: | + pip install --user virtualenvwrapper + echo "WORKON_HOME=$HOME/.virtualenvs" >> $GITHUB_ENV + shell: bash + + - name: Install virtualnvwrapper-win + if: startsWith( matrix.os, 'windows') + run: | + pip install --user virtualenvwrapper-win + echo "WORKON_HOME=$HOME/.virtualenvs" >> $GITHUB_ENV + shell: bash + - name: Install pyenv if: startsWith( matrix.os, 'windows') run: | choco install pyenv-win -y - echo PATH=$PATH;$USERPROFILE/.pyenv/pyenv-win/bin >> $GITHUB_ENV - echo PATH=$PATH;$USERPROFILE/.pyenv/pyenv-win/shims >> $GITHUB_ENV - $USERPROFILE/.pyenv/pyenv-win/bin/pyenv install 3.12.3 3.11.9 3.10.14 3.9.19 3.8.19 + echo "PATH=$PATH;$USERPROFILE/.pyenv/pyenv-win/bin" >> $GITHUB_ENV + echo "PATH=$PATH;$USERPROFILE/.pyenv/pyenv-win/shims" >> $GITHUB_ENV + echo "PYENV_ROOT="$USERPROFILE/.pyenv/pyenv-win" >> $GITHUB_ENV shell: bash - - name: Install pyenv + - name: Install pyenv and pyenv-virtualenv if: startsWith( matrix.os, 'ubuntu') || startsWith( matrix.os, 'macos') run: | curl https://pyenv.run | bash - echo PYENV_ROOT="$HOME/.pyenv" >> $GITHUB_ENV - echo PATH="$HOME/.pyenv/bin:$PATH" >> $GITHUB_ENV - ~/.pyenv/bin/pyenv install 3.12.3 3.11.9 3.10.14 3.9.19 3.8.19 + git clone https://github.com/pyenv/pyenv-virtualenv.git $HOME/.pyenv/plugins/pyenv-virtualenv + echo "PYENV_ROOT=$HOME/.pyenv" >> $GITHUB_ENV + echo "PATH=$HOME/.pyenv/bin:$PATH" >> $GITHUB_ENV + shell: bash - name: Check Pyenv version run: pyenv --version + - name: Install Pyenv Python(s) + run: pyenv install 3.12.3 3.11.9 3.10.14 3.9.19 3.8.19 + + - name: Python in Registry + if: startsWith( matrix.os, 'windows') + run: reg query HKLM\SOFTWARE\Python /s + - name: Run Tests run: cargo test --frozen --all-features From 4c0e80da641dc5229bb0d3db83c19f19a7a3ca6a Mon Sep 17 00:00:00 2001 From: Karthik Nadig Date: Tue, 4 Jun 2024 19:38:40 -0700 Subject: [PATCH 15/24] Set path better --- .github/workflows/pr-check.yml | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml index e590bfc1..32cee578 100644 --- a/.github/workflows/pr-check.yml +++ b/.github/workflows/pr-check.yml @@ -39,14 +39,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 - - name: Rust Tool Chain setup - uses: dtolnay/rust-toolchain@stable + - name: Set Python to PATH + uses: actions/setup-python@v5 with: - toolchain: stable - targets: ${{ matrix.target }} - - - name: Cargo Fetch - run: cargo fetch + python-version: "3.x" - name: Add Conda to PATH if: startsWith( matrix.os, 'windows') || startsWith( matrix.os, 'ubuntu') @@ -99,6 +95,7 @@ jobs: if: startsWith( matrix.os, 'ubuntu') || startsWith( matrix.os, 'macos') run: | curl https://pyenv.run | bash + ls $HOME/.pyenv/plugins/pyenv-virtualenv git clone https://github.com/pyenv/pyenv-virtualenv.git $HOME/.pyenv/plugins/pyenv-virtualenv echo "PYENV_ROOT=$HOME/.pyenv" >> $GITHUB_ENV echo "PATH=$HOME/.pyenv/bin:$PATH" >> $GITHUB_ENV @@ -114,6 +111,15 @@ jobs: if: startsWith( matrix.os, 'windows') run: reg query HKLM\SOFTWARE\Python /s + - name: Rust Tool Chain setup + uses: dtolnay/rust-toolchain@stable + with: + toolchain: stable + targets: ${{ matrix.target }} + + - name: Cargo Fetch + run: cargo fetch + - name: Run Tests run: cargo test --frozen --all-features From 935fe4b9037ff0f289a947a6b904564b4935d8bc Mon Sep 17 00:00:00 2001 From: Karthik Nadig Date: Tue, 4 Jun 2024 19:43:13 -0700 Subject: [PATCH 16/24] more tweaks --- .github/workflows/pr-check.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml index 32cee578..01022344 100644 --- a/.github/workflows/pr-check.yml +++ b/.github/workflows/pr-check.yml @@ -88,14 +88,14 @@ jobs: choco install pyenv-win -y echo "PATH=$PATH;$USERPROFILE/.pyenv/pyenv-win/bin" >> $GITHUB_ENV echo "PATH=$PATH;$USERPROFILE/.pyenv/pyenv-win/shims" >> $GITHUB_ENV - echo "PYENV_ROOT="$USERPROFILE/.pyenv/pyenv-win" >> $GITHUB_ENV + echo "PYENV_ROOT=$USERPROFILE/.pyenv/pyenv-win" >> $GITHUB_ENV shell: bash - name: Install pyenv and pyenv-virtualenv if: startsWith( matrix.os, 'ubuntu') || startsWith( matrix.os, 'macos') run: | curl https://pyenv.run | bash - ls $HOME/.pyenv/plugins/pyenv-virtualenv + ls -a $HOME/.pyenv/plugins/pyenv-virtualenv git clone https://github.com/pyenv/pyenv-virtualenv.git $HOME/.pyenv/plugins/pyenv-virtualenv echo "PYENV_ROOT=$HOME/.pyenv" >> $GITHUB_ENV echo "PATH=$HOME/.pyenv/bin:$PATH" >> $GITHUB_ENV From e8134ec6760cdd584ba520cad7acbc1b82ba6761 Mon Sep 17 00:00:00 2001 From: Karthik Nadig Date: Tue, 4 Jun 2024 19:49:44 -0700 Subject: [PATCH 17/24] Fix more paths --- .github/workflows/pr-check.yml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml index 01022344..40f31735 100644 --- a/.github/workflows/pr-check.yml +++ b/.github/workflows/pr-check.yml @@ -79,15 +79,14 @@ jobs: if: startsWith( matrix.os, 'windows') run: | pip install --user virtualenvwrapper-win - echo "WORKON_HOME=$HOME/.virtualenvs" >> $GITHUB_ENV + echo "WORKON_HOME=$USERPROFILE/.virtualenvs" >> $GITHUB_ENV shell: bash - name: Install pyenv if: startsWith( matrix.os, 'windows') run: | choco install pyenv-win -y - echo "PATH=$PATH;$USERPROFILE/.pyenv/pyenv-win/bin" >> $GITHUB_ENV - echo "PATH=$PATH;$USERPROFILE/.pyenv/pyenv-win/shims" >> $GITHUB_ENV + echo "PATH=$PATH;$USERPROFILE/.pyenv/pyenv-win/bin;$USERPROFILE/.pyenv/pyenv-win/shims" >> $GITHUB_ENV echo "PYENV_ROOT=$USERPROFILE/.pyenv/pyenv-win" >> $GITHUB_ENV shell: bash @@ -95,8 +94,6 @@ jobs: if: startsWith( matrix.os, 'ubuntu') || startsWith( matrix.os, 'macos') run: | curl https://pyenv.run | bash - ls -a $HOME/.pyenv/plugins/pyenv-virtualenv - git clone https://github.com/pyenv/pyenv-virtualenv.git $HOME/.pyenv/plugins/pyenv-virtualenv echo "PYENV_ROOT=$HOME/.pyenv" >> $GITHUB_ENV echo "PATH=$HOME/.pyenv/bin:$PATH" >> $GITHUB_ENV shell: bash From 6286419e44bd256148d7c415ed9137be4bafde83 Mon Sep 17 00:00:00 2001 From: Karthik Nadig Date: Tue, 4 Jun 2024 20:01:01 -0700 Subject: [PATCH 18/24] more minor tweaks --- .github/workflows/pr-check.yml | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml index 40f31735..87013d16 100644 --- a/.github/workflows/pr-check.yml +++ b/.github/workflows/pr-check.yml @@ -62,7 +62,7 @@ jobs: run: conda info --all - name: Install pipenv - run: pip install --user pipenv + run: pip install pipenv shell: bash - name: Check pipenv version @@ -71,23 +71,23 @@ jobs: - name: Install virtualnvwrapper if: startsWith( matrix.os, 'ubuntu') || startsWith( matrix.os, 'macos') run: | - pip install --user virtualenvwrapper + pip install virtualenvwrapper echo "WORKON_HOME=$HOME/.virtualenvs" >> $GITHUB_ENV shell: bash - name: Install virtualnvwrapper-win if: startsWith( matrix.os, 'windows') run: | - pip install --user virtualenvwrapper-win - echo "WORKON_HOME=$USERPROFILE/.virtualenvs" >> $GITHUB_ENV + pip install virtualenvwrapper-win + echo "WORKON_HOME=$USERPROFILE\.virtualenvs" >> $GITHUB_ENV shell: bash - name: Install pyenv if: startsWith( matrix.os, 'windows') run: | choco install pyenv-win -y - echo "PATH=$PATH;$USERPROFILE/.pyenv/pyenv-win/bin;$USERPROFILE/.pyenv/pyenv-win/shims" >> $GITHUB_ENV - echo "PYENV_ROOT=$USERPROFILE/.pyenv/pyenv-win" >> $GITHUB_ENV + echo "PATH=$PATH;$HOME/.pyenv/pyenv-win/bin;$HOME/.pyenv/pyenv-win/shims" >> $GITHUB_ENV + echo "PYENV_ROOT=$HOME/.pyenv" >> $GITHUB_ENV shell: bash - name: Install pyenv and pyenv-virtualenv @@ -103,6 +103,7 @@ jobs: - name: Install Pyenv Python(s) run: pyenv install 3.12.3 3.11.9 3.10.14 3.9.19 3.8.19 + shell: bash - name: Python in Registry if: startsWith( matrix.os, 'windows') From 829b0b4d5c99e5dade581963d1a57d2fecef068e Mon Sep 17 00:00:00 2001 From: Karthik Nadig Date: Tue, 4 Jun 2024 20:08:43 -0700 Subject: [PATCH 19/24] Tweak for windows --- .github/workflows/pr-check.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml index 87013d16..c0a0c7d1 100644 --- a/.github/workflows/pr-check.yml +++ b/.github/workflows/pr-check.yml @@ -60,6 +60,7 @@ jobs: - name: Check Conda version run: conda info --all + shell: bash - name: Install pipenv run: pip install pipenv @@ -67,6 +68,7 @@ jobs: - name: Check pipenv version run: pipenv --version + shell: bash - name: Install virtualnvwrapper if: startsWith( matrix.os, 'ubuntu') || startsWith( matrix.os, 'macos') @@ -79,7 +81,7 @@ jobs: if: startsWith( matrix.os, 'windows') run: | pip install virtualenvwrapper-win - echo "WORKON_HOME=$USERPROFILE\.virtualenvs" >> $GITHUB_ENV + echo "WORKON_HOME=$HOME/.virtualenvs" >> $GITHUB_ENV shell: bash - name: Install pyenv @@ -100,6 +102,7 @@ jobs: - name: Check Pyenv version run: pyenv --version + shell: bash - name: Install Pyenv Python(s) run: pyenv install 3.12.3 3.11.9 3.10.14 3.9.19 3.8.19 @@ -117,12 +120,15 @@ jobs: - name: Cargo Fetch run: cargo fetch + shell: bash - name: Run Tests run: cargo test --frozen --all-features + shell: bash - name: Build run: cargo build --release --target ${{ matrix.target }} + shell: bash - name: Upload Artifact uses: actions/upload-artifact@v4 From 25d1e8ceb08660df90c6d1eeab205044325914d2 Mon Sep 17 00:00:00 2001 From: Karthik Nadig Date: Tue, 4 Jun 2024 20:10:48 -0700 Subject: [PATCH 20/24] fix more paths --- .github/workflows/pr-check.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml index c0a0c7d1..e7f51e53 100644 --- a/.github/workflows/pr-check.yml +++ b/.github/workflows/pr-check.yml @@ -60,15 +60,12 @@ jobs: - name: Check Conda version run: conda info --all - shell: bash - name: Install pipenv run: pip install pipenv - shell: bash - name: Check pipenv version run: pipenv --version - shell: bash - name: Install virtualnvwrapper if: startsWith( matrix.os, 'ubuntu') || startsWith( matrix.os, 'macos') From f6c1c282d8a39f0a16a0fd9b510ef8c7b3687ccb Mon Sep 17 00:00:00 2001 From: Karthik Nadig Date: Tue, 4 Jun 2024 20:17:38 -0700 Subject: [PATCH 21/24] Debug pyenv --- .github/workflows/pr-check.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml index e7f51e53..1392bc52 100644 --- a/.github/workflows/pr-check.yml +++ b/.github/workflows/pr-check.yml @@ -102,7 +102,9 @@ jobs: shell: bash - name: Install Pyenv Python(s) - run: pyenv install 3.12.3 3.11.9 3.10.14 3.9.19 3.8.19 + run: | + pyenv install --list + pyenv install 3.12.3 3.11.9 3.10.14 3.9.19 3.8.19 shell: bash - name: Python in Registry From 4c2d5c99c49f396eba8a163ac62427888fbac6f1 Mon Sep 17 00:00:00 2001 From: Karthik Nadig Date: Tue, 4 Jun 2024 20:23:05 -0700 Subject: [PATCH 22/24] Fix pyenv-win --- .github/workflows/pr-check.yml | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml index 1392bc52..7597bba5 100644 --- a/.github/workflows/pr-check.yml +++ b/.github/workflows/pr-check.yml @@ -67,14 +67,14 @@ jobs: - name: Check pipenv version run: pipenv --version - - name: Install virtualnvwrapper + - name: Install virtualenvwrapper if: startsWith( matrix.os, 'ubuntu') || startsWith( matrix.os, 'macos') run: | pip install virtualenvwrapper echo "WORKON_HOME=$HOME/.virtualenvs" >> $GITHUB_ENV shell: bash - - name: Install virtualnvwrapper-win + - name: Install virtualenvwrapper-win if: startsWith( matrix.os, 'windows') run: | pip install virtualenvwrapper-win @@ -102,11 +102,20 @@ jobs: shell: bash - name: Install Pyenv Python(s) + if: startsWith( matrix.os, 'ubuntu') || startsWith( matrix.os, 'macos') run: | pyenv install --list pyenv install 3.12.3 3.11.9 3.10.14 3.9.19 3.8.19 shell: bash + # pyenv-win install list has not updated for a while + - name: Install Pyenv Python(s) + if: startsWith( matrix.os, 'windows') + run: | + pyenv install --list + pyenv install 3.10.5 3.9.13 3.8.10 + shell: bash + - name: Python in Registry if: startsWith( matrix.os, 'windows') run: reg query HKLM\SOFTWARE\Python /s From cf594242d0080071aa6ab6e5cc31414fa372f1d4 Mon Sep 17 00:00:00 2001 From: Karthik Nadig Date: Tue, 4 Jun 2024 20:29:12 -0700 Subject: [PATCH 23/24] Check registry via cmd --- .github/workflows/pr-check.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml index 7597bba5..40c10aac 100644 --- a/.github/workflows/pr-check.yml +++ b/.github/workflows/pr-check.yml @@ -119,6 +119,7 @@ jobs: - name: Python in Registry if: startsWith( matrix.os, 'windows') run: reg query HKLM\SOFTWARE\Python /s + shell: cmd - name: Rust Tool Chain setup uses: dtolnay/rust-toolchain@stable From 3eb92cd96ecd389b9ac7566157656d4a9464de29 Mon Sep 17 00:00:00 2001 From: Karthik Nadig Date: Tue, 4 Jun 2024 20:33:26 -0700 Subject: [PATCH 24/24] Remove reg --- .github/workflows/pr-check.yml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml index 40c10aac..97e507cf 100644 --- a/.github/workflows/pr-check.yml +++ b/.github/workflows/pr-check.yml @@ -116,11 +116,6 @@ jobs: pyenv install 3.10.5 3.9.13 3.8.10 shell: bash - - name: Python in Registry - if: startsWith( matrix.os, 'windows') - run: reg query HKLM\SOFTWARE\Python /s - shell: cmd - - name: Rust Tool Chain setup uses: dtolnay/rust-toolchain@stable with: