remove some un-used members (#4521)

Author: SimonCropp

src/AttachVS/AttachVs.cs

@@ -307,9 +307,6 @@ private static extern int NtQueryInformationProcess(
         int processInformationLength,
         out int returnLength);
 
-    [DllImport("Kernel32")]
-    private static extern uint GetTickCount();
-
     [DllImport("ole32.dll")]
     private static extern int CreateBindCtx(uint reserved, out IBindCtx ppbc);
 }

src/Microsoft.TestPlatform.Client/TestPlatform.cs

@@ -3,7 +3,6 @@
 
 using System;
 using System.Collections.Generic;
-using System.Globalization;
 using System.IO;
 using System.Linq;
 using System.Reflection;
@@ -18,14 +17,11 @@
 using Microsoft.VisualStudio.TestPlatform.ObjectModel;
 using Microsoft.VisualStudio.TestPlatform.ObjectModel.Client;
 using Microsoft.VisualStudio.TestPlatform.ObjectModel.Engine;
-using Microsoft.VisualStudio.TestPlatform.ObjectModel.Host;
 using Microsoft.VisualStudio.TestPlatform.ObjectModel.Utilities;
 using Microsoft.VisualStudio.TestPlatform.PlatformAbstractions;
 using Microsoft.VisualStudio.TestPlatform.Utilities.Helpers;
 using Microsoft.VisualStudio.TestPlatform.Utilities.Helpers.Interfaces;
 
-using ClientResources = Microsoft.VisualStudio.TestPlatform.Client.Resources.Resources;
-
 namespace Microsoft.VisualStudio.TestPlatform.Client;
 
 /// <summary>
@@ -191,18 +187,6 @@ public void ClearExtensions()
         _testEngine.GetExtensionManager().ClearExtensions();
     }
 
-    private static void ThrowExceptionIfTestHostManagerIsNull(
-        ITestRuntimeProvider? testHostManager,
-        string settingsXml)
-    {
-        if (testHostManager == null)
-        {
-            EqtTrace.Error($"{nameof(TestPlatform)}.{nameof(ThrowExceptionIfTestHostManagerIsNull)}: No suitable testHostProvider found for runsettings: {settingsXml}");
-            throw new TestPlatformException(string.Format(CultureInfo.CurrentCulture, ClientResources.NoTestHostProviderFound));
-        }
-    }
-
-
     private void AddExtensionAssemblies(string? runSettings, TestAdapterLoadingStrategy adapterLoadingStrategy)
     {
         IEnumerable<string> customTestAdaptersPaths = RunSettingsUtilities.GetTestAdaptersPaths(runSettings);

src/vstest.console/CommandLine/CommandLineOptions.cs

@@ -38,11 +38,6 @@ internal class CommandLineOptions
     /// </summary>
     public const string UseVsixExtensionsKey = "UseVsixExtensions";
 
-    /// <summary>
-    /// The default use vsix extensions value.
-    /// </summary>
-    public const bool DefaultUseVsixExtensionsValue = false;
-
     /// <summary>
     /// The default retrieval timeout for fetching of test results or test cases
     /// </summary>

src/vstest.console/Processors/Utilities/ArgumentProcessorFactory.cs

@@ -17,16 +17,6 @@ namespace Microsoft.VisualStudio.TestPlatform.CommandLine.Processors;
 /// </summary>
 internal class ArgumentProcessorFactory
 {
-    /// <summary>
-    /// The command starter.
-    /// </summary>
-    internal const string CommandStarter = "/";
-
-    /// <summary>
-    /// The xplat command starter.
-    /// </summary>
-    internal const string XplatCommandStarter = "-";
-
     /// <summary>
     /// Available argument processors.
     /// </summary>

test/Microsoft.TestPlatform.Acceptance.IntegrationTests/AcceptanceTestBase.cs

@@ -37,17 +37,14 @@ public class AcceptanceTestBase : IntegrationTestBase
     public const string InIsolation = "/InIsolation";
 
     public const string NETFX462_48 = "net462;net472;net48";
-    public const string NETCORE21_50 = "netcoreapp3.1;net5.0";
     public const string NETFX462_NET50 = "net462;net472;net48;netcoreapp3.1;net5.0";
-    public const string NETFX462_NET31 = "net462;net472;net48;netcoreapp3.1";
     public const string DEFAULT_RUNNER_NETFX = Net462TargetFramework;
     public const string DEFAULT_HOST_NETFX = Net462TargetFramework;
     public const string DEFAULT_RUNNER_NETCORE = Core31TargetFramework;
     public const string DEFAULT_HOST_NETCORE = Core31TargetFramework;
     /// <summary>
     /// Our current defaults for .NET and .NET Framework.
     /// </summary>
-    public const string DEFAULT_RUNNER_NETFX_AND_NET = $"{DEFAULT_RUNNER_NETFX};{DEFAULT_RUNNER_NETCORE}";
     public const string DEFAULT_HOST_NETFX_AND_NET = "net462;netcoreapp3.1";
     public const string LATEST_TO_LEGACY = "Latest;LatestPreview;LatestStable;RecentStable;MostDownloaded;PreviousStable;LegacyStable";
     public const string LATESTPREVIEW_TO_LEGACY = "LatestPreview;LatestStable;RecentStable;MostDownloaded;PreviousStable;LegacyStable";

test/Microsoft.TestPlatform.Acceptance.IntegrationTests/Performance/TranslationLayer/TelemetryPerfTestBase.cs

@@ -5,13 +5,11 @@
 using System;
 using System.Collections.Generic;
 using System.IO;
-using System.Reflection;
 using System.Runtime.CompilerServices;
 
 using Microsoft.ApplicationInsights;
 using Microsoft.ApplicationInsights.Extensibility;
 using Microsoft.TestPlatform.AcceptanceTests.Performance.PerfInstrumentation;
-using Microsoft.VisualStudio.TestPlatform.PlatformAbstractions;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 
 namespace Microsoft.TestPlatform.AcceptanceTests.Performance.TranslationLayer;
@@ -22,7 +20,6 @@ public class TelemetryPerfTestBase : PerformanceTestBase
 {
     private const string TelemetryInstrumentationKey = "08de1ac5-2db8-4c30-97c6-2e12695fa610";
     private readonly TelemetryClient _client;
-    private readonly string _rootDirectory = new DirectoryInfo(typeof(DiscoveryPerfTests).GetTypeInfo().Assembly.GetAssemblyLocation()).Parent.Parent.Parent.Parent.Parent.Parent.FullName;
 
     public TelemetryPerfTestBase()
     {

test/Microsoft.TestPlatform.Acceptance.IntegrationTests/TestPlatformNugetPackageTests.cs

@@ -76,12 +76,4 @@ private string CreateCodeCoverageArguments(
 
         return arguments;
     }
-
-    private static void TryMoveDirectory(string sourceDirName, string destDirName)
-    {
-        if (Directory.Exists(sourceDirName))
-        {
-            Directory.Move(sourceDirName, destDirName);
-        }
-    }
 }

test/vstest.ProgrammerTests/Fakes/StringExtensions.cs

@@ -5,11 +5,6 @@ namespace vstest.ProgrammerTests.Fakes;
 
 internal static class EnumerableExtensions
 {
-    public static string JoinBySpace<T>(this IEnumerable<T> value)
-    {
-        return value.JoinBy(" ");
-    }
-
     public static string JoinByComma<T>(this IEnumerable<T> value)
     {
         return value.JoinBy(", ");