Skip to content

Commit 0f359e3

Browse files
committed
- apply codeQL rule
- enable comment on PR with test result
1 parent 6d3b9cd commit 0f359e3

2 files changed

Lines changed: 5 additions & 6 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@ jobs:
3737
if: success() || failure() # always run even if the previous step fails
3838
with:
3939
report_paths: 'junit.xml'
40+
comment: true
41+
detailed_summary: true
4042

4143
test:
4244
if: github.event_name == 'pull_request'

__tests__/main.test.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,6 @@ import * as fs from 'fs'
55
import {clear} from '../src/transform.js'
66
import {jest} from '@jest/globals'
77
import { fileURLToPath } from 'url';
8-
import {mergeConfiguration, resolveConfiguration} from '../src/utils.js'
9-
import {ReleaseNotesBuilder} from '../src/releaseNotesBuilder.js'
10-
import {OfflineRepository} from '../src/repositories/OfflineRepository.js'
118

129
jest.setTimeout(180000)
1310
clear()
@@ -26,7 +23,7 @@ test('missing values should result in failure', () => {
2623
env: process.env
2724
}
2825
try {
29-
cp.execSync(`node ${ip}`, options).toString()
26+
cp.execFileSync('node', [ip], options).toString()
3027
} catch (error: unknown) {
3128
expect(true).toBe(true)
3229
}
@@ -64,7 +61,7 @@ test('should write result to file', () => {
6461
const options: cp.ExecSyncOptions = {
6562
env: process.env
6663
}
67-
const result = cp.execSync(`node ${ip}`, options).toString()
64+
const result = cp.execFileSync('node', [ip], options).toString()
6865
// should succeed
6966
expect(result).toBeDefined()
7067

@@ -93,7 +90,7 @@ test('offline mode should work with commit mode', () => {
9390
env: process.env
9491
}
9592

96-
const result = cp.execSync(`node ${ip}`, options).toString()
93+
const result = cp.execFileSync('node', [ip], options).toString()
9794
// should succeed
9895
expect(result).toBeDefined()
9996

0 commit comments

Comments
 (0)