Skip to content

Commit 4ed1570

Browse files
author
Carolyn Zech
committed
stop warning for --unstable-options for --jobs
1 parent 8411d21 commit 4ed1570

1 file changed

Lines changed: 15 additions & 4 deletions

File tree

kani-driver/src/args/mod.rs

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -416,12 +416,25 @@ impl VerificationArgs {
416416
}
417417
}
418418

419-
/// Given an argument, warn if UnstableFeature::UnstableOptions is enabled.
419+
/// Given the string representation of an option, warn if it's enabled UnstableFeature::UnstableOptions is enabled.
420420
/// This is for cases where the option was previously unstable but has since been stabilized.
421+
/// Example invocation: self.check_unnecessary_unstable_option(self.jobs.is_some(), "jobs");
422+
#[allow(dead_code)]
421423
pub fn check_unnecessary_unstable_option(&self, enabled: bool, option: &str) {
424+
// Note that the body of this function is subject to change; an option
425+
// will only be here if it has been stabilized *recently*, such that we should still warn about unstable-options.
426+
// So a body of just `None` is fine, since that just means that no unstable options are currently in that in-between period.
427+
// Example of an appropriate body:
428+
// ```rust
429+
// match option {
430+
// "jobs" => Some("0.63.0".to_string()),
431+
// _ => None,
432+
// }
433+
// ```
434+
// for the unstable jobs option, which was stabilized in version 0.63.
435+
#[allow(clippy::match_single_binding)]
422436
fn stabilization_version(option: &str) -> Option<String> {
423437
match option {
424-
"jobs" => Some("0.63.0".to_string()),
425438
_ => None,
426439
}
427440
}
@@ -808,8 +821,6 @@ impl ValidateArgs for VerificationArgs {
808821
// Check for any deprecated/obsolete options, or providing an unstable flag that has since been stabilized.
809822
let deprecated_stabilized_obsolete = || -> Result<(), Error> {
810823
self.checks.print_deprecated(&self.common_args);
811-
self.check_unnecessary_unstable_option(self.jobs.is_some(), "jobs");
812-
813824
if self.write_json_symtab {
814825
return Err(Error::raw(
815826
ErrorKind::ValueValidation,

0 commit comments

Comments
 (0)