Add support to array-based SIMD#2633
Merged
Merged
Conversation
Originally, repr(simd) supported only multi-field form. An array based version was later added and it's likely to become the only supported way. The array-based version is currently used in the standard library, and to implement `portable-simd`. This change adds support to instantiating and using the array-based version. We should still add more tests to check if all simd operations that Kani supports works with the array-based SIMD.
adpaco-aws
reviewed
Jul 28, 2023
Contributor
adpaco-aws
left a comment
adpaco-aws
left a comment
There was a problem hiding this comment.
Looks good, I'm just a little confused about what is it that the tests are doing.
adpaco-aws
reviewed
Jul 31, 2023
adpaco-aws
approved these changes
Jul 31, 2023
celinval
added a commit
that referenced
this pull request
Aug 4, 2023
Change #2633 was incomplete and it doesn't work in the context of generic functions. This PR fixes that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Originally, repr(simd) supported only multi-field form. An array based version was later added and it's likely to become the only supported way (rust-lang/compiler-team#621).
The array-based version is currently used in the standard library, and it is used to implement
portable-simd. This change adds support to instantiating and using the array-based version.Resolved issues:
Resolves #2590
Resolves #1926
Related RFC:
Optional #ISSUE-NUMBER.
Call-outs:
We should still add more tests to check if all simd operations that Kani supports works with the array-based SIMD. I'm planning on doing that in a follow up PR.
Testing:
How is this change tested? New tests
Is this a refactor change?
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.