Skip to content

Commit bb5b285

Browse files
committed
Address missed feedback from #1021
1 parent 1ee552a commit bb5b285

File tree

2 files changed

+6
-15
lines changed

2 files changed

+6
-15
lines changed

src/ModelContextProtocol.Core/Client/McpClientImpl.cs

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -104,17 +104,11 @@ private void RegisterHandlers(McpClientOptions options, NotificationHandlers not
104104
McpJsonUtilities.JsonContext.Default.ElicitResult);
105105

106106
_options.Capabilities ??= new();
107-
if (_options.Capabilities.Elicitation is null)
107+
_options.Capabilities.Elicitation ??= new();
108+
if (_options.Capabilities.Elicitation.Form is null &&
109+
_options.Capabilities.Elicitation.Url is null)
108110
{
109-
// Default to supporting only form mode if not explicitly configured
110-
_options.Capabilities.Elicitation = new()
111-
{
112-
Form = new(),
113-
};
114-
}
115-
else if (_options.Capabilities.Elicitation.Form is null && _options.Capabilities.Elicitation.Url is null)
116-
{
117-
// If ElicitationCapability is set but both modes are null, default to form mode for backward compatibility
111+
// If both modes are null, default to form mode for backward compatibility.
118112
_options.Capabilities.Elicitation.Form = new();
119113
}
120114
}

src/ModelContextProtocol.Core/Protocol/ElicitationCapability.cs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,6 @@ public sealed class Converter : JsonConverter<ElicitationCapability>
7070
}
7171

7272
var capability = new ElicitationCapability();
73-
bool hasForm = false;
74-
bool hasUrl = false;
7573

7674
foreach (var property in document.RootElement.EnumerateObject())
7775
{
@@ -80,19 +78,18 @@ public sealed class Converter : JsonConverter<ElicitationCapability>
8078
capability.Form = property.Value.ValueKind == JsonValueKind.Null
8179
? null
8280
: capability.Form ?? new FormElicitationCapability();
83-
hasForm = true;
8481
}
8582
else if (property.NameEquals("url"))
8683
{
8784
capability.Url = property.Value.ValueKind == JsonValueKind.Null
8885
? null
8986
: capability.Url ?? new UrlElicitationCapability();
90-
hasUrl = capability.Url is not null;
9187
}
9288
}
9389

94-
if (!hasForm && !hasUrl)
90+
if (capability.Form is null && capability.Url is null)
9591
{
92+
// If both modes are null, default to form mode for backward compatibility.
9693
capability.Form = new FormElicitationCapability();
9794
}
9895

0 commit comments

Comments
 (0)