Added thread_creation_silent#2887
Closed
zoemartin01 wants to merge 2 commits into
Closed
Conversation
… functionality if desired
Contributor
|
You forgot to add the config in |
… more consistent with the other names and added it to config_help.json
zoemartin01
changed the title
thread_auto_open_silentlythread_creation_silent
fourjr
reviewed
Nov 18, 2020
| }, | ||
| "thread_creation_silent": { | ||
| "default": "No", | ||
| "description": "Setting this configuration will open a new thread silently by default.", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "description": "Setting this configuration will open a new thread silently by default.", | |
| "description": "Setting this configuration will always open a new thread silently in contact.", |
fourjr
requested changes
Nov 18, 2020
fourjr
left a comment
fourjr
left a comment
Collaborator
There was a problem hiding this comment.
Config variable should be changed to thread_contact_silent as it only affects contact
fourjr
reviewed
Nov 18, 2020
| "thread_auto_close_response": "This thread has been closed automatically due to inactivity after {timeout}.", | ||
| "thread_creation_response": "The staff team will get back to you as soon as possible.", | ||
| "thread_creation_footer": "Your message has been sent", | ||
| "thread_creation_silent": False, |
Collaborator
There was a problem hiding this comment.
it has to be added to booleans too
Collaborator
|
Thanks for the contributions! This PR has been merged in a123bf6, not sure why the PR wasn't autoclosed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just added
thread_auto_open_silentlywith the default value 'false' as this allows for the users customisation on a recently changed feature.