MAF-19232: fix(e2e): Enhance image parsing and improve error handling

- Updated the ParseImage function to return an error if the image format is invalid, ensuring better validation.
- Modified the createInferencePerfJob function to handle parsing errors gracefully, improving robustness in performance tests.
- Reorganized the deletion of Heimdall in quality tests for better clarity and consistency.

Author: seongsu-dev

test/e2e/performance/performance_test.go

@@ -151,7 +151,10 @@ func waitForInferenceService(namespace string, name string) error {
 }
 
 func createInferencePerfJob(namespace string, baseURL string, image string, isKind bool) (string, error) {
-	_, imageTag := utils.ParseImage(image)
+	_, imageTag, err := utils.ParseImage(image)
+	if err != nil {
+		return "", fmt.Errorf("failed to parse image: %w", err)
+	}
 
 	type jobTemplateData struct {
 		Namespace         string

test/e2e/quality/quality_test.go

@@ -103,9 +103,6 @@ var _ = Describe("Quality Benchmark", Label("quality"), Ordered, func() {
 		utils.DeleteInferenceService(envs.WorkloadNamespace, prefillServiceName)
 		utils.DeleteInferenceService(envs.WorkloadNamespace, decodeServiceName)
 
-		By("deleting Heimdall")
-		utils.UninstallHeimdall(envs.WorkloadNamespace)
-
 		if envs.SkipKind {
 			By("deleting model PVC")
 			utils.DeleteModelPVC(envs.WorkloadNamespace, pvcName)
@@ -114,6 +111,9 @@ var _ = Describe("Quality Benchmark", Label("quality"), Ordered, func() {
 			utils.DeleteModelPV(pvName)
 		}
 
+		By("deleting Heimdall")
+		utils.UninstallHeimdall(envs.WorkloadNamespace)
+
 		By("deleting Gateway resources")
 		utils.DeleteGatewayResource(envs.WorkloadNamespace, envs.GatewayClassName)
 

test/utils/common.go

@@ -146,10 +146,17 @@ func hasAllCRDs(output string, required []string) bool {
 }
 
 // ParseImage parses a container image reference
-func ParseImage(image string) (repo, tag string) {
+func ParseImage(image string) (repo, tag string, err error) {
 	lastColon := strings.LastIndex(image, ":")
+	if lastColon == -1 {
+		return image, "", fmt.Errorf("invalid image: %s", image)
+	}
+	if lastColon == len(image)-1 {
+		return image[:lastColon], "", fmt.Errorf("invalid image: %s", image)
+	}
+
 	repo = image[:lastColon]
 	tag = image[lastColon+1:]
 
-	return repo, tag
+	return repo, tag, nil
 }