Skip to content

Commit 234eef8

Browse files
authored
Build RPM packages for currently supported Fedora releases (#10879)
* Build RPM packages for currently supported Fedora releases * Fix unused-result warning/error in WebExtCommand::run * Fix artifact filename * Fetch supported Fedora releases from endoflife.data
1 parent 27b7425 commit 234eef8

2 files changed

Lines changed: 28 additions & 5 deletions

File tree

.github/workflows/linux.yaml

Lines changed: 23 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,19 @@ concurrency:
1414
cancel-in-progress: true
1515

1616
jobs:
17+
supported-fedora-releases:
18+
name: Fetch currently supported Fedora releases
19+
runs-on: ubuntu-22.04
20+
outputs:
21+
supported-releases: ${{ steps.fetch-supported-releases.outputs.releases }}
22+
steps:
23+
- id: fetch-supported-releases
24+
name: Fetch currently supported Fedora releases
25+
run: |
26+
API_RESPONSE=$(curl -s https://endoflife.date/api/v1/products/fedora)
27+
SUPPORTED_RELEASES=$(echo $API_RESPONSE | jq -c '[ .result.releases[] | select(.isEol == false) | { "fedora-version": .name } ]')
28+
echo "releases=$SUPPORTED_RELEASES" >> $GITHUB_OUTPUT
29+
1730
source-bundle:
1831
name: Source Bundle
1932
runs-on: ubuntu-22.04
@@ -45,11 +58,17 @@ jobs:
4558
include-hidden-files: true
4659

4760
rpmbuild:
48-
name: RPM Packages
49-
needs: source-bundle
61+
name: RPM Packages (Fedora ${{ matrix.fedora-version }})
62+
needs:
63+
- source-bundle
64+
- supported-fedora-releases
5065
runs-on: ubuntu-latest
66+
strategy:
67+
fail-fast: false
68+
matrix:
69+
include: ${{ fromJSON(needs.supported-fedora-releases.outputs.supported-releases) }}
5170
container:
52-
image: fedora:42
71+
image: fedora:${{ matrix.fedora-version }}
5372

5473
steps:
5574
- name: Download Source Package
@@ -70,7 +89,7 @@ jobs:
7089
- name: Uploading
7190
uses: actions/upload-artifact@v4
7291
with:
73-
name: RPM Build
92+
name: RPM Build (Fedora ${{ matrix.fedora-version }})
7493
path: |
7594
RPMS/
7695
SRPMS/

src/webextension/webextcommand.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,11 @@ int WebExtCommand::run(QStringList& tokens) {
7878
}
7979

8080
QFile stdoutFile;
81-
stdoutFile.open(stdout, QIODeviceBase::WriteOnly);
81+
if (!stdoutFile.open(stdout, QIODeviceBase::WriteOnly)) {
82+
qWarning() << "Failed to open stdout: " << stdoutFile.errorString();
83+
return 1;
84+
};
85+
8286
WebExtHandler handler(&stdoutFile);
8387
QObject::connect(&handler, &WebExtHandler::eofReceived, &app,
8488
&QCoreApplication::quit);

0 commit comments

Comments
 (0)