LightingModel: Refactor indirect lighting (#28824)

Author: sunag

src/nodes/core/LightingModel.js

@@ -8,9 +8,7 @@ class LightingModel {
 
 	directRectArea( /*input, stack, builder*/ ) {}
 
-	indirectDiffuse( /*input, stack, builder*/ ) { }
-
-	indirectSpecular( /*input, stack, builder*/ ) { }
+	indirect( /*input, stack, builder*/ ) { }
 
 	ambientOcclusion( /*input, stack, builder*/ ) { }
 

src/nodes/functions/BasicLightingModel.js

@@ -12,7 +12,7 @@ class BasicLightingModel extends LightingModel {
 
 	}
 
-	indirectDiffuse( { ambientOcclusion, reflectedLight } ) {
+	indirect( { ambientOcclusion, reflectedLight } ) {
 
 		reflectedLight.indirectDiffuse.addAssign( diffuseColor.rgb );
 

src/nodes/functions/PhongLightingModel.js

@@ -56,7 +56,7 @@ class PhongLightingModel extends BasicLightingModel {
 
 	}
 
-	indirectDiffuse( { ambientOcclusion, irradiance, reflectedLight } ) {
+	indirect( { ambientOcclusion, irradiance, reflectedLight } ) {
 
 		reflectedLight.indirectDiffuse.addAssign( irradiance.mul( BRDF_Lambert( { diffuseColor } ) ) );
 

src/nodes/functions/PhysicalLightingModel.js

@@ -507,6 +507,14 @@ class PhysicalLightingModel extends LightingModel {
 
 	}
 
+	indirect( context, stack, builder ) {
+
+		this.indirectDiffuse( context, stack, builder );
+		this.indirectSpecular( context, stack, builder );
+		this.ambientOcclusion( context, stack, builder );
+
+	}
+
 	indirectDiffuse( { irradiance, reflectedLight } ) {
 
 		reflectedLight.indirectDiffuse.addAssign( irradiance.mul( BRDF_Lambert( { diffuseColor } ) ) );

src/nodes/functions/ToonLightingModel.js

@@ -38,7 +38,7 @@ class ToonLightingModel extends LightingModel {
 
 	}
 
-	indirectDiffuse( { ambientOcclusion, irradiance, reflectedLight } ) {
+	indirect( { ambientOcclusion, irradiance, reflectedLight } ) {
 
 		reflectedLight.indirectDiffuse.addAssign( irradiance.mul( BRDF_Lambert( { diffuseColor } ) ) );
 

src/nodes/lighting/LightsNode.js

@@ -99,9 +99,7 @@ class LightsNode extends Node {
 
 			//
 
-			lightingModel.indirectDiffuse( context, stack, builder );
-			lightingModel.indirectSpecular( context, stack, builder );
-			lightingModel.ambientOcclusion( context, stack, builder );
+			lightingModel.indirect( context, stack, builder );
 
 			//