Skip to content

CI: Remove merge command.#28403

Merged
Mugen87 merged 1 commit into
mrdoob:devfrom
Mugen87:dev78
May 17, 2024
Merged

CI: Remove merge command.#28403
Mugen87 merged 1 commit into
mrdoob:devfrom
Mugen87:dev78

Conversation

@Mugen87
Copy link
Copy Markdown
Collaborator

@Mugen87 Mugen87 commented May 17, 2024

Related issue: #28401 (comment)

Description

It seems the CI is reported as failed because of the merge command. Trying to remove it to see if it solves the issue.

@Mugen87 Mugen87 merged commit 1a89bb5 into mrdoob:dev May 17, 2024
@Mugen87 Mugen87 added this to the r165 milestone May 17, 2024
@Mugen87
Copy link
Copy Markdown
Collaborator Author

Mugen87 commented May 17, 2024

It seems this indeed helps.

So renaming the upload artifact was sufficient when upgrading actions/upload-artifact to v4. The merge command is not required at all.

@mrdoob
Copy link
Copy Markdown
Owner

mrdoob commented May 17, 2024

Oh I see... 37e1cb5 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants