WebGPURenderer: Allow using StorageBuffer directly as attribute in nodes#28620
Merged
sunag merged 1 commit intoJun 11, 2024
Merged
Conversation
Mugen87
approved these changes
Jun 11, 2024
This was referenced Jun 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using storage buffers directly as vertex node it will consume them as basic attribute and generates this type of error (in both backend):
This PR fixes the issue as properly binding the attribute as storage buffer instead of VERTEX | COPY_SRC | COPY_DST
This contribution is funded by Utsubo