Skip to content

Effects: Use FullScreenQuad.#29126

Merged
Mugen87 merged 1 commit into
mrdoob:devfrom
Mugen87:dev4
Aug 13, 2024
Merged

Effects: Use FullScreenQuad.#29126
Mugen87 merged 1 commit into
mrdoob:devfrom
Mugen87:dev4

Conversation

@Mugen87
Copy link
Copy Markdown
Collaborator

@Mugen87 Mugen87 commented Aug 13, 2024

Related issue: -

Description

AnaglyphEffect and ParallaxBarrierEffect can make use of FullScreenQuad which simplifies the code a bit.

Besides, the PR adds the missing dispose() method to ParallaxBarrierEffect.

@Mugen87 Mugen87 added this to the r168 milestone Aug 13, 2024
@Mugen87
Copy link
Copy Markdown
Collaborator Author

Mugen87 commented Aug 13, 2024

BTW: I think we can port StereoEffect, AnaglyphEffect and ParallaxBarrierEffect as StereoPassNode, AnaglyphPassNode and ParallaxBarrierPassNode in nodes/display. They would be used via PostProcessing like so:

postProcessing = new THREE.PostProcessing( renderer );

const stereoScenePass = stereoPass( scene, camera );
// const anaglyphScenePass = anaglyphPass( scene, camera );
// const parallaxBarrierScenePass = parallaxBarrierPass( scene, camera );

postProcessing.outputNode = stereoScenePass;

@Mugen87 Mugen87 merged commit 90c34c0 into mrdoob:dev Aug 13, 2024
@mrdoob
Copy link
Copy Markdown
Owner

mrdoob commented Aug 14, 2024

BTW: I think we can port StereoEffect, AnaglyphEffect and ParallaxBarrierEffect as StereoPassNode, AnaglyphPassNode and ParallaxBarrierPassNode in nodes/display.

Agreed! And would be great to remove these files eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants