DDSLoader: Add 24bit uncompressed RGB support.#30010
Merged
Merged
Conversation
Adds support for 24bit uncompressed RGB textured to DDSLoader. The texture data is read from the file in RGB, and returned in RGBA format with a=1.
Collaborator
|
Interesting. Do you mind updating the webgl_loader_texture_dds and use such a 24 bit texture so we have a test case for validation? |
Collaborator
|
To make the CI work, you have to regenerate the examples E2E screenshot via: Besides, please revert the changes to |
Contributor
Author
|
I'll re-generate the examples |
Clean up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for 24bit uncompressed RGB textures to DDSLoader. The texture data is read from the file in RGB, and returned in RGBA format with a=1.
I came across a bumpmap texture that was using this format that could not be parsed by DDSLoader. I've attached the texture for reference.
wave_normals.zip