Skip to content

WebGPUUtils: Ensure sample count is valid#31352

Merged
Mugen87 merged 2 commits into
mrdoob:devfrom
ycw:1
Jul 2, 2025
Merged

WebGPUUtils: Ensure sample count is valid#31352
Mugen87 merged 2 commits into
mrdoob:devfrom
ycw:1

Conversation

@ycw
Copy link
Copy Markdown
Contributor

@ycw ycw commented Jul 1, 2025

Description

This PR ensures sample count used by Texture(sampleCount) or Pipeline(multisample.count) must be 1 or 4

Defined at:

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 1, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 337.69
78.76
337.69
78.76
+0 B
+0 B
WebGPU 557.35
154.34
557.29
154.31
-60 B
-23 B
WebGPU Nodes 556.27
154.12
556.21
154.09
-60 B
-23 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 468.91
113.45
468.91
113.45
+0 B
+0 B
WebGPU 632.98
171.34
632.91
171.31
-60 B
-22 B
WebGPU Nodes 588.11
160.69
588.05
160.67
-60 B
-22 B

@Mugen87 Mugen87 added this to the r179 milestone Jul 2, 2025
@Mugen87 Mugen87 merged commit c5f48e4 into mrdoob:dev Jul 2, 2025
12 checks passed
@ycw ycw deleted the 1 branch July 5, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants