fix linter violations

Author: mrtazz

Makefile.am

@@ -30,7 +30,12 @@ valgrind: check
 	valgrind --leak-check=full --error-exitcode=1 ./test-program
 
 lint:
-	cpplint --filter=-legal/copyright --root=$(CURDIR) include/restclient-cpp/*.h source/*.cc
+	# Filter reasons:
+	#  legal/copyright: it's just maintenance overhead to have license headers
+	#  in all files
+	#  whitespace/indent_namespace: it makes code less readable if indentations
+	#  in namespaces are not allowed
+	cpplint --filter="-legal/copyright,-whitespace/indent_namespace" --root=$(CURDIR) include/restclient-cpp/*.h source/*.cc
 
 docker-services:
 	[ -n "$$(docker ps --quiet --filter name=restclient-cpp-httpbin)" ] || \

source/connection.cc

@@ -8,11 +8,12 @@
 
 #include <curl/curl.h>
 
+#include <algorithm>
 #include <cstring>
-#include <string>
 #include <iostream>
 #include <map>
 #include <stdexcept>
+#include <string>
 #include <utility>
 
 #include "restclient-cpp/restclient.h"
@@ -378,7 +379,7 @@ RestClient::Connection::performCurlRequest(const std::string& uri) {
  *
  * @param uri URI to query
  * @param ret Reference to the response struct that should be filled
- * 
+ *
  * @return reference to response struct for chaining
  */
 RestClient::Response*
@@ -571,7 +572,7 @@ RestClient::Connection::get(const std::string& url) {
  *
  * @param url to query
  * @param response struct
- * 
+ *
  * @return response struct ref for chaining
  */
 RestClient::Response*

source/helpers.cc

@@ -7,6 +7,7 @@
 #include "restclient-cpp/helpers.h"
 
 #include <cstring>
+#include <string>
 
 #include "restclient-cpp/restclient.h"
 

source/restclient.cc

@@ -17,6 +17,8 @@
 #if __cplusplus >= 201402L
 #include <memory>
 #endif
+#include <string>
+
 
 #include "restclient-cpp/version.h"
 #include "restclient-cpp/connection.h"