Skip to content

Commit 9b58f4e

Browse files
committed
HACK media: qcom: camss: fix VFE pm domain off
Fix NULL pointer check before device_link_del is called. Unable to handle kernel NULL pointer dereference at virtual address 000000000000032c Call trace: device_link_put_kref+0xc/0xb8 device_link_del+0x30/0x48 vfe_pm_domain_off+0x24/0x38 [qcom_camss] vfe_put+0x9c/0xd0 [qcom_camss] vfe_set_power+0x48/0x58 [qcom_camss] pipeline_pm_power_one+0x154/0x158 [videodev] pipeline_pm_power+0x74/0xfc [videodev] v4l2_pipeline_pm_use+0x54/0x90 [videodev] v4l2_pipeline_pm_put+0x14/0x34 [videodev] video_release+0x2c/0x44 [qcom_camss] v4l2_release+0xe4/0xec [videodev] Fixes: eb73fac ("media: qcom: camss: Use common VFE pm_domain_on/pm_domain_off where applicable") Tested-by: Yassine Oudjana <y.oudjana@protonmail.com> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
1 parent 78cef3d commit 9b58f4e

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/media/platform/qcom/camss/camss-vfe.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -596,7 +596,7 @@ void vfe_isr_reset_ack(struct vfe_device *vfe)
596596
*/
597597
void vfe_pm_domain_off(struct vfe_device *vfe)
598598
{
599-
if (!vfe->genpd)
599+
if (!vfe->genpd_link)
600600
return;
601601

602602
device_link_del(vfe->genpd_link);

0 commit comments

Comments
 (0)