Simplify configuration/configLocation mutual exclusion check#1244
Open
wlswo wants to merge 1 commit into
Open
Conversation
The boolean expression in SqlSessionFactoryBean.afterPropertiesSet()
was logically equivalent to a much simpler form. This change replaces
it with the minimal equivalent expression and resolves the existing
TODO comment.
Also fixes a minor grammatical issue in the error message
('can not specified with together' -> 'can not be specified together')
and updates the corresponding test assertion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the
// TODO Review this statement as it seems off!comment inSqlSessionFactoryBean.afterPropertiesSet()by simplifying the boolean expression to its logically equivalent minimal form, and fixes a minor grammatical issue in the error message.Logical equivalence
Let
A = (configuration == null)andB = (configLocation == null).Original expression:
By De Morgan's law:
!(¬A && ¬B) ≡ A || B, so the expression becomes(A && B) || (A || B). By absorption (A && BimpliesA || B), this reduces toA || B.The simplified expression preserves the original semantics: at least one of
configurationorconfigLocationmust benull— i.e. they cannot both be specified.Changes
SqlSessionFactoryBean.afterPropertiesSet(): simplified the booleanexpression and removed the now-resolved TODO comment.
"can not specified with together""can not be specified together"SqlSessionFactoryBeanTest.testSpecifyConfigurationAndConfigLocationto assert against the new error message.
Verification
./mvnw verify— BUILD SUCCESS, 222 tests, 0 failures, 15 skipped (same as baseline).