Breaking: deprecate safe-buffer.Buffer calls (#110)

ChALkeR · mysticatea · commit 2dbf74175b0b · 2018-03-09T14:58:02.000+09:00
safe-buffer.Buffer function/constructror is just a re-export of
buffer.Buffer and should be deprecated likewise.

Otherwise, using Buffer = require('safe-buffer').Buffer magically hides
the deprecation message, which it shouldn't, as that code will
actually cause runtime deprecation errors on Node.js &gt;= 10.
diff --git a/lib/util/deprecated-apis.js b/lib/util/deprecated-apis.js
@@ -417,3 +417,7 @@ module.exports = {
         },
     },
 }
+
+// safe-buffer.Buffer function/constructror is just a re-export of buffer.Buffer
+// and should be deprecated likewise.
+module.exports.modules["safe-buffer"] = module.exports.modules.buffer

Original file line number	Diff line number	Diff line change
`@@ -417,3 +417,7 @@ module.exports = {`
`417`	`417`	`},`
`418`	`418`	`},`
`419`	`419`	`}`
	`420`	`+`
	`421`	`+// safe-buffer.Buffer function/constructror is just a re-export of buffer.Buffer`
	`422`	`+// and should be deprecated likewise.`
	`423`	`+module.exports.modules["safe-buffer"] = module.exports.modules.buffer`