wip: start implementing last_send tracking for PTO#279
Closed
dignifiedquire wants to merge 1 commit intomainfrom
Closed
wip: start implementing last_send tracking for PTO#279dignifiedquire wants to merge 1 commit intomainfrom
dignifiedquire wants to merge 1 commit intomainfrom
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/quinn/pr/279/docs/iroh_quinn/ Last updated: 2025-12-17T18:02:15Z |
Frando
reviewed
Dec 18, 2025
| pub(crate) fn timer_offset(&self, now: Instant, duration: Duration) -> Instant { | ||
| let start = self.last_sent.unwrap_or(now); | ||
| let end = start + duration; | ||
| if end > start { |
Member
There was a problem hiding this comment.
should be if end > now I think?
matheus23
reviewed
Dec 18, 2025
Comment on lines
+678
to
+679
| let end = self.calculate_end_timer(now, 3, SpaceId::Data); | ||
| let extended_end = self.calculate_end_timer(now, 6, SpaceId::Data); |
Member
There was a problem hiding this comment.
Suggested change
| let end = self.calculate_end_timer(now, 3, SpaceId::Data); | |
| let extended_end = self.calculate_end_timer(now, 6, SpaceId::Data); | |
| let last_allowed_receive = self.calculate_end_timer(now, 3, SpaceId::Data); | |
| let path_discard = self.calculate_end_timer(now, 6, SpaceId::Data); |
Collaborator
|
Only cursory looking at this, but I'm fairly sure that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.