Skip to content

Commit b2b9403

Browse files
committed
remove hard-coding hostname
1 parent dffd835 commit b2b9403

6 files changed

Lines changed: 14 additions & 7 deletions

File tree

gerrit/run

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ run() {
7373
git config -f review_site/etc/gerrit.config auth.httpHeader REMOTE_USER
7474
git config -f review_site/etc/gerrit.config auth.httpDisplaynameHeader OIDC_CLAIM_name
7575
git config -f review_site/etc/gerrit.config auth.httpEmailHeader OIDC_CLAIM_email
76-
git config -f review_site/etc/gerrit.config auth.emailFormat "{0}@nsbox.internal"
76+
git config -f review_site/etc/gerrit.config auth.emailFormat "{0}@$hostname"
7777
git config -f review_site/etc/gerrit.config auth.allowRegisterNewEmail false
7878
git config -f review_site/etc/gerrit.config auth.enableRunAs false
7979
git config -f review_site/etc/gerrit.config receive.timeout 15min

keycloak/createuser

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ set -o pipefail
66

77
createuser() {
88
local realm="nsbox"
9+
local hostname="nsbox.internal"
910
local loginDomain="login.nsbox.internal"
1011

1112
# Initialize variables with default or empty values
@@ -15,6 +16,11 @@ createuser() {
1516

1617
while [[ $# -gt 0 ]]; do
1718
case "$1" in
19+
"--hostname")
20+
shift
21+
hostname="$1"
22+
echo "Using hostname $hostname instead of nsbox.internal"
23+
;;
1824
"--login-domain")
1925
shift
2026
loginDomain="$1"
@@ -45,7 +51,7 @@ createuser() {
4551
exit 1
4652
fi
4753

48-
local email="$username@nsbox.internal"
54+
local email="$username@$hostname"
4955

5056
cd "$HOME"
5157
export KEYCLOAK_HOME="$HOME/keycloak"

portal/buildbot.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -346,11 +346,11 @@ func PrepareBuildbotAccountInGerrit() ([]*gerrit.Project, error) {
346346
}
347347

348348
// Ensure the user exists
349-
if err := AddGerritUser(username, "Buildbot", "buildbot@nsbox.internal"); err != nil {
349+
if err := AddGerritUser(username, "Buildbot", "buildbot@"+*hostname); err != nil {
350350
return nil, fmt.Errorf("error ensuring user exists: %w", err)
351351
}
352352

353-
client := gerrit.NewClient("http://"+*bindIP+":8081", "admin", "Administrator", "admin@nsbox.internal")
353+
client := gerrit.NewClient("http://"+*bindIP+":8081", "admin", "Administrator", "admin@"+*hostname)
354354
if err := client.Login(); err != nil {
355355
return nil, fmt.Errorf("error logging into gerrit: %w", err)
356356
}
@@ -400,7 +400,7 @@ func StopBuildbot() {
400400

401401
func WatchGerritProjects() {
402402
for {
403-
client := gerrit.NewClient("http://"+*bindIP+":8081", "admin", "Administrator", "admin@nsbox.internal")
403+
client := gerrit.NewClient("http://"+*bindIP+":8081", "admin", "Administrator", "admin@"+*hostname)
404404
if err := client.Login(); err != nil {
405405
log.Printf("WatchGerritProjects: error logging into gerrit: %v", err)
406406
time.Sleep(30 * time.Second)

portal/gerrit.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ func StartGerrit() error {
7272
return err
7373
}
7474
WaitGerritUp()
75-
if err := AddGerritUser("admin", "Administrator", "admin@nsbox.internal"); err != nil {
75+
if err := AddGerritUser("admin", "Administrator", "admin@"+*hostname); err != nil {
7676
return err
7777
}
7878
return nil

portal/keycloak.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -244,6 +244,7 @@ func AddKeycloakUser(username, firstname, lastname string) (string, error) {
244244

245245
cmd := exec.Command("podman", "exec", "keycloak",
246246
"/home/keycloak/createuser",
247+
"--hostname", *hostname,
247248
"--login-domain", *loginDomain,
248249
"--username", username,
249250
"--first-name", firstname,

portal/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ func handleCreateUser(w http.ResponseWriter, r *http.Request) {
221221
}
222222

223223
// Add user to Gerrit (idempotent operation)
224-
err = AddGerritUser(username, firstName+" "+lastName, username+"@nsbox.internal")
224+
err = AddGerritUser(username, firstName+" "+lastName, username+"@"+*hostname)
225225
if err != nil {
226226
http.Error(w, "Failed to add user to Gerrit: "+err.Error(), http.StatusInternalServerError)
227227
return

0 commit comments

Comments
 (0)