Modify Claim Screen (Windows Installer)#19132
Merged
thiagoftsm merged 2 commits intonetdata:masterfrom Dec 6, 2024
Merged
Conversation
github-actions
bot
added
the
area/packaging
thiagoftsm
force-pushed
the
hide_options
branch
from
3f0d265 to
6f2f017
Compare
stelfrag
reviewed
Dec 6, 2024
stelfrag
approved these changes
Dec 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is modifying our installer to hide all fields on Claim Screen when there is already a claim.conf file generated during installation time.
Test Plan
c:\Program Files\Netdata\etc\netdata\claim.confand run the installer. You should have the following screen:c:\Program Files\Netdata\etc\netdata\claim.conf. Run the installer again, this time you will have the following screen:Additional Information
For users: How does this change affect me?
Describe the PR affects users: - Which area of Netdata is affected by the change? Installer - Can they see the change or is it an under the hood? If they can see it, where? Only when installing software. - How is the user impacted by the change? They have a clear vision about connection with cloud. - What are there any benefits of the change? Avoid confusions and save time during installation.