Skip to content

Improve estimated disk space usage for data file rotation#20019

Merged
stelfrag merged 2 commits intonetdata:masterfrom
stelfrag:improve_calculate_disk_cap
Apr 2, 2025
Merged

Improve estimated disk space usage for data file rotation#20019
stelfrag merged 2 commits intonetdata:masterfrom
stelfrag:improve_calculate_disk_cap

Conversation

@stelfrag
Copy link
Collaborator

@stelfrag stelfrag commented Apr 1, 2025

Summary
  • Enhance protection of the structures used in disk space calculation.
  • Prevent queuing the database rotate opcode on every extent write.

@stelfrag stelfrag marked this pull request as ready for review April 1, 2025 07:50
@stelfrag stelfrag force-pushed the improve_calculate_disk_cap branch from 7915eb7 to 5d0d5bd Compare April 1, 2025 11:30
Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR ran as expected for more than one hour. LGTM!

@stelfrag stelfrag merged commit 9019b56 into netdata:master Apr 2, 2025
101 of 102 checks passed
@stelfrag stelfrag deleted the improve_calculate_disk_cap branch April 2, 2025 09:13
stelfrag added a commit to stelfrag/netdata that referenced this pull request Apr 9, 2025
)

* Add locks to protect the datafile disk space calculation

* Avoid queueing RRDENG_OPCODE_DATABASE_ROTATE operations needlessly

(cherry picked from commit 9019b56)
@stelfrag stelfrag mentioned this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants