Skip to content

improvement(cgroups): improve systemd-nspawn filter for default#20168

Merged
ilyam8 merged 1 commit intonetdata:masterfrom
rhoriguchi:master
Apr 24, 2025
Merged

improvement(cgroups): improve systemd-nspawn filter for default#20168
ilyam8 merged 1 commit intonetdata:masterfrom
rhoriguchi:master

Conversation

@rhoriguchi
Copy link
Contributor

Summary

Follow-up to #20155

Test Plan

Ran a single systemd-nspawn container. Modified the filters till there was a single entry.

Additional Information
For users: How does this change affect me?

@rhoriguchi rhoriguchi requested a review from thiagoftsm as a code owner April 23, 2025 20:17
@CLAassistant
Copy link

CLAassistant commented Apr 23, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added area/collectors Everything related to data collection collectors/cgroups labels Apr 23, 2025
@ilyam8 ilyam8 merged commit f1aecd8 into netdata:master Apr 24, 2025
106 checks passed
@ilyam8
Copy link
Member

ilyam8 commented Apr 24, 2025

Thanks, @rhoriguchi, for catching this and correcting! I tested those patterns by adding them to the enable by default cgroups matching (running Netdata), but forgot to add the necessary heading spaces to the patterns in my PR 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/collectors Everything related to data collection collectors/cgroups

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants