Skip to content

Add Rocky Linux 10 to CI and package builds.#20578

Merged
Ferroin merged 2 commits intonetdata:masterfrom
Ferroin:rocky-10
Jun 26, 2025
Merged

Add Rocky Linux 10 to CI and package builds.#20578
Ferroin merged 2 commits intonetdata:masterfrom
Ferroin:rocky-10

Conversation

@Ferroin
Copy link
Member

@Ferroin Ferroin commented Jun 25, 2025

Summary

This provides package builds for RHEL 10, Alma Linux 10, and Rocky Linux 10.

Test Plan

The new CI jobs pass on this PR.

@Ferroin Ferroin marked this pull request as ready for review June 25, 2025 15:06
@Ferroin Ferroin requested a review from a team as a code owner June 25, 2025 15:06
@Ferroin Ferroin requested a review from a team June 25, 2025 15:07
Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this PR based on the CI results. LGTM!

@ilyam8 ilyam8 requested a review from Copilot June 25, 2025 17:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends CI and package build support to include RHEL 10, Alma Linux 10, and Rocky Linux 10 by updating various distro configuration entries.

  • Updates the Rocky Linux configuration from version "9" to "10" and adds a new base_image reference.
  • Adjusts the repo_distro and alt_links values for Rocky Linux to match the new version.
  • Updates the RHEL configuration from version "9.x" to "10.x" and maintains an alias for the previous version.
Comments suppressed due to low confidence (3)

.github/data/distros.yml:301

  • It is unclear why there is a separate rocky entry for version '9' after updating the main rocky block to version '10'. Consider adding a comment to clarify the purpose of maintaining legacy configuration.
  - <<: *rocky

.github/data/distros.yml:306

  • The 'repo_distro' remains set to 'el/9' in the legacy block despite the primary configuration updating to 'el/10'. If this discrepancy is intentional for legacy support, please add a comment explaining the rationale.
      repo_distro: el/9

.github/data/distros.yml:281

  • [nitpick] Consider adding a comment explaining why a fully qualified image URL is used for Rocky Linux 10, whereas the legacy entry for version '9' uses a shorthand notation.
    base_image: "quay.io/rockylinux/rockylinux:10"

@Ferroin Ferroin merged commit 32b1931 into netdata:master Jun 26, 2025
130 checks passed
@Ferroin Ferroin deleted the rocky-10 branch June 26, 2025 11:06
@jamesharr
Copy link

Hi @Ferroin, packages don't seem to appear in the public repository yet. Do you know when it's going to appear in the repo?

I also posted a question in Discord under #general

@Ferroin
Copy link
Member Author

Ferroin commented Jul 10, 2025

Hi @Ferroin, packages don't seem to appear in the public repository yet. Do you know when it's going to appear in the repo?

It will show up in the stable release channel once we actually create a stable release with these changes.

I don’t recall if we have a concrete date yet, but we should have a new minor release soon, and this will be included in that release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants