Skip to content

Improve agent shutdown on windows#20672

Merged
stelfrag merged 2 commits intonetdata:masterfrom
stelfrag:improve_shutdown_on_windows
Jul 14, 2025
Merged

Improve agent shutdown on windows#20672
stelfrag merged 2 commits intonetdata:masterfrom
stelfrag:improve_shutdown_on_windows

Conversation

@stelfrag
Copy link
Collaborator

Summary
  • Improve agent shutdown time on windows
    • If a separate thread is created for a plugin, make sure to join on shutdown

@github-actions github-actions bot added area/collectors Everything related to data collection collectors/windows labels Jul 14, 2025
@stelfrag stelfrag marked this pull request as ready for review July 14, 2025 10:30
@stelfrag stelfrag requested a review from thiagoftsm as a code owner July 14, 2025 10:30
Copy link
Contributor

@thiagoftsm thiagoftsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is working as expected on WIndows 11, 2019 Server, and 2022 server. LGTM!

@stelfrag stelfrag merged commit b94e935 into netdata:master Jul 14, 2025
151 of 153 checks passed
@stelfrag stelfrag deleted the improve_shutdown_on_windows branch July 14, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/collectors Everything related to data collection collectors/windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants