Skip to content

Commit 1831a64

Browse files
authored
Merge pull request #1985 from nextcloud-libraries/refactor/remove-html
chore(dialogs)!: remove deprecated `setHTML` method
2 parents 95c159f + 320deec commit 1831a64

2 files changed

Lines changed: 1 addition & 14 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ For Vue 3 apps nothing changed, meaning the app and this library will share the
3333
* This package now uses Vue 3 internally.
3434
* The deprecated FilePicker component export was removed to allow using this library in Vue 2 and Vue 3 apps.
3535
* The deprecated `Dialog.hide` method was removed, instead await the returned promise and wait for the user interaction.
36+
* The deprecated `Dialog.setHTML` method was removed. If you need custom HTML content use `NcDialog` from `@nextcloud/vue`.
3637
* The `spawnDialog` helper method was removed, instead use the function provided by `@nextcloud/vue`
3738
```diff
3839
- import { spawnDialog } from '@nextcloud/dialogs'

lib/dialogs.ts

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,6 @@ export class Dialog {
2020
#buttons: IDialogButton[]
2121
#severity?: IDialogSeverity
2222

23-
/** @deprecated */
24-
#html?: string
25-
2623
constructor(
2724
name: string,
2825
text: string,
@@ -33,16 +30,6 @@ export class Dialog {
3330
this.#text = text
3431
this.#buttons = buttons
3532
this.#severity = severity
36-
this.#html = undefined
37-
}
38-
39-
/**
40-
* @deprecated DO NOT USE! It will be removed in the near future!
41-
* @param html HTML content
42-
*/
43-
setHTML(html: string) {
44-
this.#html = html
45-
return this
4633
}
4734

4835
/**
@@ -58,7 +45,6 @@ export class Dialog {
5845
name: this.#name,
5946
text: this.#text,
6047
severity: this.#severity,
61-
html: this.#html,
6248
},
6349
)
6450
if (!result) {

0 commit comments

Comments
 (0)