fix: review comment

luka-nextcloud · luka-nextcloud · commit 15c26ec162ce · 2023-11-21T10:08:21.000+01:00
Signed-off-by: Luka Trovic &lt;luka@nextcloud.com&gt;
diff --git a/lib/private/TemplateLayout.php b/lib/private/TemplateLayout.php
@@ -209,7 +209,6 @@ public function __construct($renderAs, $appId = '') {
 				$showSimpleSignup = false;
 			}
 
-			$urlGenerator = \OCP\Server::get(IURLGenerator::class);
 			$defaultSignUpLink = 'https://nextcloud.com/signup/';
 			$signUpLink = $this->config->getSystemValueString('registration_link', $defaultSignUpLink);
 			if ($signUpLink !== $defaultSignUpLink) {
@@ -218,6 +217,7 @@ public function __construct($renderAs, $appId = '') {
 
 			$appManager = \OCP\Server::get(IAppManager::class);
 			if ($appManager->isEnabledForUser('registration')) {
+				$urlGenerator = \OCP\Server::get(IURLGenerator::class);
 				$signUpLink = $urlGenerator->getAbsoluteURL('/index.php/apps/registration/');
 			}
 

Original file line number	Diff line number	Diff line change
`@@ -209,7 +209,6 @@ public function __construct($renderAs, $appId = '') {`
`209`	`209`	`$showSimpleSignup = false;`
`210`	`210`	`}`
`211`	`211`
`212`		`- $urlGenerator = \OCP\Server::get(IURLGenerator::class);`
`213`	`212`	`$defaultSignUpLink = 'https://nextcloud.com/signup/';`
`214`	`213`	`$signUpLink = $this->config->getSystemValueString('registration_link', $defaultSignUpLink);`
`215`	`214`	`if ($signUpLink !== $defaultSignUpLink) {`
`@@ -218,6 +217,7 @@ public function __construct($renderAs, $appId = '') {`
`218`	`217`
`219`	`218`	`$appManager = \OCP\Server::get(IAppManager::class);`
`220`	`219`	`if ($appManager->isEnabledForUser('registration')) {`
	`220`	`+ $urlGenerator = \OCP\Server::get(IURLGenerator::class);`
`221`	`221`	`$signUpLink = $urlGenerator->getAbsoluteURL('/index.php/apps/registration/');`
`222`	`222`	`}`
`223`	`223`