Explicitly check if username is false or not

akhil1508 · akhil1508 · commit 2c8516524a06 · 2024-03-21T20:04:04.000+05:30
Signed-off-by: Akhil &lt;akhil@e.email&gt;
diff --git a/apps/user_ldap/lib/User_LDAP.php b/apps/user_ldap/lib/User_LDAP.php
@@ -180,7 +180,7 @@ public function getLDAPUserByLoginName($loginName) {
 	 */
 	public function checkPassword($uid, $password) {
 		$username = $this->loginName2UserName($uid, true);
-		if (!$username) {
+		if ($username === false) {
 			return false;
 		}
 		$dn = $this->access->username2dn($username);

Original file line number	Diff line number	Diff line change
`@@ -180,7 +180,7 @@ public function getLDAPUserByLoginName($loginName) {`
`180`	`180`	`*/`
`181`	`181`	`public function checkPassword($uid, $password) {`
`182`	`182`	`$username = $this->loginName2UserName($uid, true);`
`183`		`- if (!$username) {`
	`183`	`+ if ($username === false) {`
`184`	`184`	`return false;`
`185`	`185`	`}`
`186`	`186`	`$dn = $this->access->username2dn($username);`