Skip to content

Commit 4e35864

Browse files
committed
fix api controller contstruction and routes
Signed-off-by: Robin Appelman <[email protected]>
1 parent f3f890f commit 4e35864

File tree

3 files changed

+17
-35
lines changed

3 files changed

+17
-35
lines changed

apps/files/appinfo/routes.php

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -50,44 +50,44 @@
5050
],
5151

5252
[
53-
'name' => 'API#getThumbnail',
53+
'name' => 'Api#getThumbnail',
5454
'url' => '/api/v1/thumbnail/{x}/{y}/{file}',
5555
'verb' => 'GET',
5656
'requirements' => ['file' => '.+']
5757
],
5858
[
59-
'name' => 'API#updateFileTags',
59+
'name' => 'Api#updateFileTags',
6060
'url' => '/api/v1/files/{path}',
6161
'verb' => 'POST',
6262
'requirements' => ['path' => '.+'],
6363
],
6464
[
65-
'name' => 'API#getRecentFiles',
65+
'name' => 'Api#getRecentFiles',
6666
'url' => '/api/v1/recent/',
6767
'verb' => 'GET'
6868
],
6969
[
70-
'name' => 'API#updateFileSorting',
70+
'name' => 'Api#updateFileSorting',
7171
'url' => '/api/v1/sorting',
7272
'verb' => 'POST'
7373
],
7474
[
75-
'name' => 'API#showHiddenFiles',
75+
'name' => 'Api#showHiddenFiles',
7676
'url' => '/api/v1/showhidden',
7777
'verb' => 'POST'
7878
],
7979
[
80-
'name' => 'API#cropImagePreviews',
80+
'name' => 'Api#cropImagePreviews',
8181
'url' => '/api/v1/cropimagepreviews',
8282
'verb' => 'POST'
8383
],
8484
[
85-
'name' => 'API#showGridView',
85+
'name' => 'Api#showGridView',
8686
'url' => '/api/v1/showgridview',
8787
'verb' => 'POST'
8888
],
8989
[
90-
'name' => 'API#getGridView',
90+
'name' => 'Api#getGridView',
9191
'url' => '/api/v1/showgridview',
9292
'verb' => 'GET'
9393
],
@@ -102,12 +102,12 @@
102102
'verb' => 'GET',
103103
],
104104
[
105-
'name' => 'API#toggleShowFolder',
105+
'name' => 'Api#toggleShowFolder',
106106
'url' => '/api/v1/toggleShowFolder/{key}',
107107
'verb' => 'POST'
108108
],
109109
[
110-
'name' => 'API#getNodeType',
110+
'name' => 'Api#getNodeType',
111111
'url' => '/api/v1/quickaccess/get/NodeType',
112112
'verb' => 'GET',
113113
],

apps/files/lib/AppInfo/Application.php

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -75,25 +75,6 @@ public function __construct(array $urlParams = []) {
7575
}
7676

7777
public function register(IRegistrationContext $context): void {
78-
/**
79-
* Controllers
80-
*/
81-
$context->registerService('APIController', function (ContainerInterface $c) {
82-
/** @var IServerContainer $server */
83-
$server = $c->get(IServerContainer::class);
84-
85-
return new ApiController(
86-
$c->get('AppName'),
87-
$c->get(IRequest::class),
88-
$c->get(IUserSession::class),
89-
$c->get(TagService::class),
90-
$c->get(IPreview::class),
91-
$c->get(IShareManager::class),
92-
$c->get(IConfig::class),
93-
$server->getUserFolder()
94-
);
95-
});
96-
9778
/**
9879
* Services
9980
*/

apps/files/lib/Controller/ApiController.php

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838
namespace OCA\Files\Controller;
3939

4040
use OC\Files\Node\Node;
41+
use OCA\Files\AppInfo\Application;
4142
use OCA\Files\Service\TagService;
4243
use OCA\Files\SidebarNavigationManager;
4344
use OCP\AppFramework\Controller;
@@ -48,6 +49,7 @@
4849
use OCP\AppFramework\Http\Response;
4950
use OCP\Files\File;
5051
use OCP\Files\Folder;
52+
use OCP\Files\IRootFolder;
5153
use OCP\Files\NotFoundException;
5254
use OCP\IConfig;
5355
use OCP\IPreview;
@@ -78,33 +80,32 @@ class ApiController extends Controller {
7880
private $navigationManager;
7981

8082
/**
81-
* @param string $appName
8283
* @param IRequest $request
8384
* @param IUserSession $userSession
8485
* @param TagService $tagService
8586
* @param IPreview $previewManager
8687
* @param IManager $shareManager
8788
* @param IConfig $config
88-
* @param Folder $userFolder
89+
* @param IRootFolder $rootFolder
90+
* @param SidebarNavigationManager $navigationManager
8991
*/
9092
public function __construct(
91-
$appName,
9293
IRequest $request,
9394
IUserSession $userSession,
9495
TagService $tagService,
9596
IPreview $previewManager,
9697
IManager $shareManager,
9798
IConfig $config,
98-
Folder $userFolder,
99+
IRootFolder $rootFolder,
99100
SidebarNavigationManager $navigationManager
100101
) {
101-
parent::__construct($appName, $request);
102+
parent::__construct(Application::APP_ID, $request);
102103
$this->userSession = $userSession;
103104
$this->tagService = $tagService;
104105
$this->previewManager = $previewManager;
105106
$this->shareManager = $shareManager;
106107
$this->config = $config;
107-
$this->userFolder = $userFolder;
108+
$this->userFolder = $rootFolder->getUserFolder($userSession->getUser()->getUID());
108109
$this->navigationManager = $navigationManager;
109110
}
110111

0 commit comments

Comments
 (0)