Skip to content

Commit 4ece2f2

Browse files
authored
Merge pull request #42032 from nextcloud/backport/unified-search-headings
[stable28] fix(UnifiedSearch): Move headings out of list element (invalid HTML)
2 parents 52aadb5 + fd580e5 commit 4ece2f2

File tree

4 files changed

+14
-13
lines changed

4 files changed

+14
-13
lines changed

core/src/views/UnifiedSearch.vue

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,10 @@
3636
<!-- Search form & filters wrapper -->
3737
<div class="unified-search__input-wrapper">
3838
<div class="unified-search__input-row">
39-
<NcTextField :value.sync="query"
39+
<NcTextField ref="input"
40+
:value.sync="query"
4041
trailing-button-icon="close"
4142
:label="ariaLabel"
42-
ref="input"
4343
:trailing-button-label="t('core','Reset search')"
4444
:show-trailing-button="query !== ''"
4545
aria-describedby="unified-search-desc"
@@ -90,16 +90,14 @@
9090
</template>
9191

9292
<!-- Grouped search results -->
93-
<template v-else>
94-
<ul v-for="({list, type}, typesIndex) in orderedResults"
95-
:key="type"
93+
<template v-for="({list, type}, typesIndex) in orderedResults" v-else>
94+
<h2 :key="type" class="unified-search__results-header">
95+
{{ typesMap[type] }}
96+
</h2>
97+
<ul :key="type"
9698
class="unified-search__results"
9799
:class="`unified-search__results-${type}`"
98100
:aria-label="typesMap[type]">
99-
<h2 class="unified-search__results-header">
100-
{{ typesMap[type] }}
101-
</h2>
102-
103101
<!-- Search results -->
104102
<li v-for="(result, index) in limitIfAny(list, type)" :key="result.resourceUrl">
105103
<SearchResult v-bind="result"

dist/core-unified-search.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/core-unified-search.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tsconfig.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"extends": "@vue/tsconfig/tsconfig.json",
3-
"include": ["./apps/**/*.ts", "./apps/**/*.vue", "./core/**/*.ts", "./*.d.ts"],
3+
"include": ["./apps/**/*.ts", "./apps/**/*.vue", "./core/**/*.ts", "./core/**/*.vue", "./*.d.ts"],
44
"compilerOptions": {
55
"types": ["jest", "node", "vue", "vue-router"],
66
"outDir": "./dist/",
@@ -18,6 +18,9 @@
1818
"resolveJsonModule": true,
1919
"strict": true,
2020
},
21+
"vueCompilerOptions": {
22+
"target": 2.7
23+
},
2124
"ts-node": {
2225
// these options are overrides used only by ts-node
2326
// same as our --compilerOptions flag and our TS_NODE_COMPILER_OPTIONS environment variable

0 commit comments

Comments
 (0)