Skip to content

Commit 6235a66

Browse files
committed
Don't send executionContexts for Clear-Site-Data
There are plans to remove executionContexts from the spec: w3c/webappsec-clear-site-data#59 Firefox already removed it https://bugzilla.mozilla.org/show_bug.cgi?id=1548034 Chromium implementation is not finish: https://bugs.chromium.org/p/chromium/issues/detail?id=898503&q=clear-site-data&sort=-modified&colspec=ID%20Pri%20M%20Stars%20ReleaseBlock%20Component%20Status%20Owner%20Summary%20OS%20Modified Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
1 parent eb092bb commit 6235a66

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

core/Controller/LoginController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ public function logout() {
128128

129129
$this->session->set('clearingExecutionContexts', '1');
130130
$this->session->close();
131-
$response->addHeader('Clear-Site-Data', '"cache", "storage", "executionContexts"');
131+
$response->addHeader('Clear-Site-Data', '"cache", "storage"');
132132
return $response;
133133
}
134134

tests/Core/Controller/LoginControllerTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ public function testLogoutWithoutToken() {
138138
->willReturn('/login');
139139

140140
$expected = new RedirectResponse('/login');
141-
$expected->addHeader('Clear-Site-Data', '"cache", "storage", "executionContexts"');
141+
$expected->addHeader('Clear-Site-Data', '"cache", "storage"');
142142
$this->assertEquals($expected, $this->loginController->logout());
143143
}
144144

@@ -168,7 +168,7 @@ public function testLogoutWithToken() {
168168
->willReturn('/login');
169169

170170
$expected = new RedirectResponse('/login');
171-
$expected->addHeader('Clear-Site-Data', '"cache", "storage", "executionContexts"');
171+
$expected->addHeader('Clear-Site-Data', '"cache", "storage"');
172172
$this->assertEquals($expected, $this->loginController->logout());
173173
}
174174

0 commit comments

Comments
 (0)