fix(files-external): do not load lazy appconfig from construct

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>

Author: ArtificialOwl

apps/files_external/lib/Service/BackendService.php

@@ -35,11 +35,9 @@ class BackendService {
 	/** Priority constants for PriorityTrait */
 	public const PRIORITY_DEFAULT = 100;
 
-	/** @var bool */
-	private $userMountingAllowed = true;
-
+	private ?bool $userMountingAllowed = null;
 	/** @var string[] */
-	private $userMountingBackends = [];
+	private array $userMountingBackends = [];
 
 	/** @var Backend[] */
 	private $backends = [];
@@ -59,16 +57,8 @@ class BackendService {
 	private $configHandlers = [];
 
 	public function __construct(
-		protected IAppConfig $appConfig,
+		protected readonly IAppConfig $appConfig,
 	) {
-		// Load config values
-		$this->userMountingAllowed = $appConfig->getValueBool('files_external', ConfigLexicon::ALLOW_USER_MOUNTING);
-		$this->userMountingBackends = explode(',', $appConfig->getValueString('files_external', ConfigLexicon::USER_MOUNTING_BACKENDS));
-
-		// if no backend is in the list an empty string is in the array and user mounting is disabled
-		if ($this->userMountingBackends === ['']) {
-			$this->userMountingAllowed = false;
-		}
 	}
 
 	/**
@@ -249,6 +239,7 @@ public function getAuthMechanism($identifier) {
 	 * @return bool
 	 */
 	public function isUserMountingAllowed() {
+		$this->loadUserMountingConfig();
 		return $this->userMountingAllowed;
 	}
 
@@ -259,6 +250,7 @@ public function isUserMountingAllowed() {
 	 * @return bool
 	 */
 	protected function isAllowedUserBackend(Backend $backend) {
+		$this->loadUserMountingConfig();
 		if ($this->userMountingAllowed
 			&& array_intersect($backend->getIdentifierAliases(), $this->userMountingBackends)
 		) {
@@ -339,4 +331,22 @@ public function getConfigHandlers() {
 		$this->loadConfigHandlers();
 		return $this->configHandlers;
 	}
+
+	/**
+	 * retrieve and cache config value related to user mounting
+	 */
+	private function loadUserMountingConfig(): void {
+		if ($this->userMountingAllowed !== null) {
+			return;
+		}
+
+		// Load config values
+		$this->userMountingAllowed = $this->appConfig->getValueBool('files_external', ConfigLexicon::ALLOW_USER_MOUNTING);
+		$this->userMountingBackends = explode(',', $this->appConfig->getValueString('files_external', ConfigLexicon::USER_MOUNTING_BACKENDS));
+
+		// if no backend is in the list an empty string is in the array and user mounting is disabled
+		if ($this->userMountingBackends === ['']) {
+			$this->userMountingAllowed = false;
+		}
+	}
 }