Skip to content

Commit ce22dcc

Browse files
committed
feat(Navigation): enable target blank on Administration settings
Signed-off-by: Fitrah Munir <fitrahmunir@outlook.com>
1 parent aa4bc56 commit ce22dcc

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

lib/private/NavigationManager.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -294,6 +294,7 @@ private function init() {
294294
'id' => 'admin_settings',
295295
'order' => 4,
296296
'href' => $this->urlGenerator->linkToRoute('settings.AdminSettings.index', ['section' => 'overview']),
297+
'target' => '_blank',
297298
'name' => $l->t('Administration settings'),
298299
'icon' => $this->urlGenerator->imagePath('settings', 'admin.svg'),
299300
]);

tests/lib/NavigationManagerTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,8 @@ public function providesNavigationConfig() {
343343
'active' => false,
344344
'type' => 'settings',
345345
'classes' => '',
346-
'unread' => 0
346+
'unread' => 0,
347+
'target' => '_blank',
347348
]
348349
];
349350

0 commit comments

Comments
 (0)