Merge pull request #47521 from nextcloud/fix/noid/loosing-systemconfig-on-setup

fix(logger): ignore session logging during setup

Author: ArtificialOwl

lib/base.php

@@ -387,10 +387,15 @@ public static function initSession(): void {
 		$sessionName = OC_Util::getInstanceId();
 
 		try {
+			$logger = null;
+			if (Server::get(\OC\SystemConfig::class)->getValue('installed', false)) {
+				$logger = logger('core');
+			}
+
 			// set the session name to the instance id - which is unique
 			$session = new \OC\Session\Internal(
 				$sessionName,
-				logger('core'),
+				$logger,
 			);
 
 			$cryptoWrapper = Server::get(\OC\Session\CryptoWrapper::class);

lib/private/Session/Internal.php

@@ -29,8 +29,10 @@ class Internal extends Session {
 	 * @param string $name
 	 * @throws \Exception
 	 */
-	public function __construct(string $name,
-		private LoggerInterface $logger) {
+	public function __construct(
+		string $name,
+		private ?LoggerInterface $logger,
+	) {
 		set_error_handler([$this, 'trapError']);
 		$this->invoke('session_name', [$name]);
 		$this->invoke('session_cache_limiter', ['']);
@@ -204,7 +206,7 @@ private function invoke(string $functionName, array $parameters = [], bool $sile
 					$timeSpent > 0.5 => ILogger::INFO,
 					default => ILogger::DEBUG,
 				};
-				$this->logger->log(
+				$this->logger?->log(
 					$logLevel,
 					"Slow session operation $functionName detected",
 					[