Correctly check the reception of a remote feedback

Signed-off-by: Louis Chemineau <louis@chmn.me>

Author: artonge

apps/federatedfilesharing/lib/Notifications.php

@@ -405,7 +405,7 @@ protected function tryLegacyEndPoint($remoteDomain, $urlSuffix, array $fields) {
 	 * @param $fields
 	 * @param $action
 	 *
-	 * @return bool
+	 * @return array|false
 	 */
 	protected function tryOCMEndPoint($remoteDomain, $fields, $action) {
 		switch ($action) {

apps/files_sharing/lib/External/Manager.php

@@ -365,7 +365,7 @@ public function processNotification($remoteShare) {
 	private function sendFeedbackToRemote($remote, $token, $remoteId, $feedback) {
 		$result = $this->tryOCMEndPoint($remote, $token, $remoteId, $feedback);
 
-		if ($result === true) {
+		if (is_array($result)) {
 			return true;
 		}
 
@@ -401,7 +401,7 @@ private function sendFeedbackToRemote($remote, $token, $remoteId, $feedback) {
 	 * @param string $token
 	 * @param string $remoteId id of the share
 	 * @param string $feedback
-	 * @return bool
+	 * @return array|false
 	 */
 	protected function tryOCMEndPoint($remoteDomain, $token, $remoteId, $feedback) {
 		switch ($feedback) {

lib/private/Federation/CloudFederationProviderManager.php

@@ -167,7 +167,7 @@ public function sendShare(ICloudFederationShare $share) {
 	/**
 	 * @param string $url
 	 * @param ICloudFederationNotification $notification
-	 * @return mixed
+	 * @return array|false
 	 */
 	public function sendNotification($url, ICloudFederationNotification $notification) {
 		$ocmEndPoint = $this->getOCMEndPoint($url);

lib/public/Federation/ICloudFederationProviderManager.php

@@ -89,7 +89,7 @@ public function sendShare(ICloudFederationShare $share);
 	 *
 	 * @param string $url
 	 * @param ICloudFederationNotification $notification
-	 * @return mixed
+	 * @return array|false
 	 *
 	 * @since 14.0.0
 	 */