Skip to content

Commit eecf776

Browse files
committed
Better primary visual on public pages
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
1 parent e03bc6e commit eecf776

File tree

2 files changed

+16
-3
lines changed

2 files changed

+16
-3
lines changed

apps/files_sharing/css/public.scss

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,19 @@ thead {
184184
}
185185
}
186186

187+
// hide the download entry on the menu
188+
// on public share when NOT on mobile
189+
@media only screen and (min-width: 769px) {
190+
#body-public {
191+
.header-right {
192+
#header-actions-menu {
193+
> ul > li#download {
194+
display: none;
195+
}
196+
}
197+
}
198+
}
199+
}
187200
// hide the primary on public share on mobile
188201
@media only screen and (max-width: 768px) {
189202
#body-public {

core/templates/layout.public.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,18 +51,18 @@
5151
?>
5252
<div class="header-right">
5353
<span id="header-primary-action" class="<?php if($template->getActionCount() === 1) { p($primary->getIcon()); } ?>">
54-
<a href="<?php p($primary->getLink()); ?>">
54+
<a href="<?php p($primary->getLink()); ?>" class="primary button">
5555
<span><?php p($primary->getLabel()) ?></span>
5656
</a>
5757
</span>
58-
<?php if($template->getActionCount()>1) { ?>
58+
<?php if($template->getActionCount() > 1) { ?>
5959
<div id="header-secondary-action">
6060
<span id="header-actions-toggle" class="menutoggle icon-more-white"></span>
6161
<div id="header-actions-menu" class="popovermenu menu">
6262
<ul>
6363
<?php
6464
/** @var \OCP\AppFramework\Http\Template\IMenuAction $action */
65-
foreach($template->getOtherActions() as $action) {
65+
foreach($others as $action) {
6666
print_unescaped($action->render());
6767
}
6868
?>

0 commit comments

Comments
 (0)