Merge pull request #468 from nextcloud/artonge/fix/getById

artonge · web-flow · commit ce994e141075 · 2026-02-03T12:16:59.000+01:00
fix: Migrate `getById` to `getFirstNodeById`
diff --git a/lib/Operation.php b/lib/Operation.php
@@ -113,12 +113,10 @@ public function onEvent(string $eventName, Event $event, IRuleMatcher $ruleMatch
 				if ($event->getObjectType() !== 'files') {
 					return;
 				}
-				$nodes = $this->rootFolder->getById((int)$event->getObjectId());
-				if (!isset($nodes[0])) {
+				$node = $this->rootFolder->getFirstNodeById((int)$event->getObjectId());
+				if ($node === null) {
 					return;
 				}
-				$node = $nodes[0];
-				unset($nodes);
 			} else {
 				$node = $event->getSubject();
 			}

Original file line number	Diff line number	Diff line change
`@@ -113,12 +113,10 @@ public function onEvent(string $eventName, Event $event, IRuleMatcher $ruleMatch`
`113`	`113`	`if ($event->getObjectType() !== 'files') {`
`114`	`114`	`return;`
`115`	`115`	`}`
`116`		`- $nodes = $this->rootFolder->getById((int)$event->getObjectId());`
`117`		`- if (!isset($nodes[0])) {`
	`116`	`+ $node = $this->rootFolder->getFirstNodeById((int)$event->getObjectId());`
	`117`	`+ if ($node === null) {`
`118`	`118`	`return;`
`119`	`119`	`}`
`120`		`- $node = $nodes[0];`
`121`		`- unset($nodes);`
`122`	`120`	`} else {`
`123`	`121`	`$node = $event->getSubject();`
`124`	`122`	`}`