Skip to content

Commit 767636d

Browse files
committed
lookup: declare bankruptcy on flaky modules
Remove all modules that failed the latest 20.x release run. We need to be able to trust that a failed CITGM run is something that needs to be investigated.
1 parent 8b6acfb commit 767636d

File tree

3 files changed

+14
-111
lines changed

3 files changed

+14
-111
lines changed

lib/lookup.json

Lines changed: 12 additions & 106 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,6 @@
5555
"prefix": "v",
5656
"skip": ["win32", "aix"]
5757
},
58-
"bluebird": {
59-
"prefix": "v",
60-
"maintainers": "petkaantonov"
61-
},
6258
"body-parser": {
6359
"flaky": "aix",
6460
"maintainers": "dougwilson"
@@ -90,7 +86,7 @@
9086
"maintainers": "mcollina",
9187
"flaky": ["rhel"],
9288
"prefix": "v",
93-
"skip": ["aix", "win32"]
89+
"skip": ["aix", "darwin", "win32"]
9490
},
9591
"coffeescript": {
9692
"maintainers": ["jashkenas", "GeoffreyBooth"],
@@ -105,20 +101,11 @@
105101
"maintainers": "ctalkington",
106102
"skip": "win32"
107103
},
108-
"csv-parser": {
109-
"prefix": "v",
110-
"flaky": "win32",
111-
"maintainers": "mafintosh"
112-
},
113104
"debug": {
114105
"maintainers": ["qix", "tootallnate"],
115106
"skip": [true, "aix", "ppc", "s390", "win32"],
116107
"scripts": ["test:node", "lint"]
117108
},
118-
"dicer": {
119-
"prefix": "v",
120-
"maintainers": "mscdex"
121-
},
122109
"duplexer2": {
123110
"prefix": "v",
124111
"maintainers": ["shinn", "deoxxa"]
@@ -127,14 +114,6 @@
127114
"prefix": "v",
128115
"maintainers": "mafintosh"
129116
},
130-
"ember-cli": {
131-
"envVar": { "YARN_IGNORE_ENGINES": "true" },
132-
"prefix": "v",
133-
"flaky": ["win32", "rhel", "sles"],
134-
"head": true,
135-
"expectFail": "fips",
136-
"maintainers": ["stefanpenner", "rwjblue", "Turbo87", "kellyselden"]
137-
},
138117
"end-of-stream": {
139118
"prefix": "v",
140119
"maintainers": "mafintosh",
@@ -153,19 +132,10 @@
153132
"expectFail": "fips",
154133
"skip": ["win32"]
155134
},
156-
"express": {
157-
"flaky": "ppc",
158-
"maintainers": "dougwilson",
159-
"skip": "win32"
160-
},
161135
"express-session": {
162136
"prefix": "v",
163137
"maintainers": "dougwilson"
164138
},
165-
"fastify": {
166-
"maintainers": ["mcollina", "delvedor"],
167-
"prefix": "v"
168-
},
169139
"flush-write-stream": {
170140
"prefix": "v",
171141
"maintainers": "mafintosh",
@@ -214,10 +184,6 @@
214184
"maintainers": "contra",
215185
"skip": "win32"
216186
},
217-
"https-proxy-agent": {
218-
"maintainers": "TooTallNate",
219-
"scripts": ["build", "test"]
220-
},
221187
"iconv": {
222188
"prefix": "v",
223189
"flaky": "aix",
@@ -235,6 +201,7 @@
235201
},
236202
"is-core-module": {
237203
"prefix": "v",
204+
"skip": "win32",
238205
"maintainers": "ljharb",
239206
"scripts": ["tests-only"]
240207
},
@@ -277,13 +244,6 @@
277244
"maintainers": ["ralphtheninja", "vweevers"],
278245
"skip": "win32"
279246
},
280-
"leveldown": {
281-
"prefix": "v",
282-
"useGitClone": true,
283-
"flaky": ["ppc", "s390"],
284-
"tags": "native",
285-
"maintainers": ["ralphtheninja", "vweevers"]
286-
},
287247
"libxmljs": {
288248
"prefix": "v",
289249
"flaky": ["aix", "sles", "rhel", "darwin"],
@@ -308,13 +268,10 @@
308268
"tags": "native",
309269
"maintainers": "wadey"
310270
},
311-
"mime": {
312-
"prefix": "v",
313-
"maintainers": "broofa"
314-
},
315271
"minimist": {
316272
"npm": true,
317-
"maintainers": "substack"
273+
"skip": "win32",
274+
"maintainers": "ljharb"
318275
},
319276
"mkdirp": {
320277
"head": true,
@@ -332,18 +289,6 @@
332289
"maintainers": "ichernev",
333290
"skip": [true, "ppc", "s390"]
334291
},
335-
"multer": {
336-
"prefix": "v",
337-
"skip": "win32",
338-
"maintainers": "linusu"
339-
},
340-
"nan": {
341-
"maintainers": ["nodejs/addon-api"],
342-
"prefix": "v",
343-
"scripts": ["rebuild-tests", "test"],
344-
"tags": "native",
345-
"head": true
346-
},
347292
"node-gyp": {
348293
"envVar": { "FAST_TEST": "true" },
349294
"prefix": "v",
@@ -358,11 +303,6 @@
358303
"comment": "Flaky because of test timeouts",
359304
"skip": true
360305
},
361-
"npm": {
362-
"maintainers": ["nodejs/npm"],
363-
"prefix": "v",
364-
"skip": ["aix", "s390"]
365-
},
366306
"path-to-regexp": {
367307
"prefix": "v",
368308
"maintainers": "blakeembrey",
@@ -386,11 +326,6 @@
386326
"comment": "Error message changes in V8 9.3",
387327
"repo": "https://github.com/pugjs/pug"
388328
},
389-
"pump": {
390-
"prefix": "v",
391-
"maintainers": "mafintosh",
392-
"skip": "win32"
393-
},
394329
"pumpify": {
395330
"prefix": "v",
396331
"maintainers": "mafintosh",
@@ -426,17 +361,8 @@
426361
},
427362
"rewire": {
428363
"prefix": "v",
429-
"maintainers": "jhnns"
430-
},
431-
"rimraf": {
432-
"prefix": "v",
433-
"flaky": "win32",
434-
"maintainers": "isaacs"
435-
},
436-
"router": {
437-
"prefix": "v",
438-
"maintainers": "dougwilson",
439-
"skip": "win32"
364+
"maintainers": "jhnns",
365+
"scripts": ["test -- --timeout 30000"]
440366
},
441367
"sax": {
442368
"skip": "win32",
@@ -454,10 +380,8 @@
454380
},
455381
"serialport": {
456382
"prefix": "serialport@",
457-
"flaky": ["ppc", "rhel"],
458383
"tags": "native",
459-
"maintainers": "reconbot",
460-
"skip": ["win32"]
384+
"maintainers": "reconbot"
461385
},
462386
"socket.io": {
463387
"maintainers": "rauchg",
@@ -497,7 +421,9 @@
497421
"tape": {
498422
"head": true,
499423
"prefix": "v",
500-
"maintainers": "substack"
424+
"skip": "win32",
425+
"scripts": ["tests-only"],
426+
"maintainers": "ljharb"
501427
},
502428
"thread-sleep": {
503429
"install": ["install", "--build-from-source"],
@@ -517,30 +443,13 @@
517443
"stripAnsi": true,
518444
"maintainers": "mcollina"
519445
},
520-
"torrent-stream": {
521-
"prefix": "v",
522-
"maintainers": "mafintosh"
523-
},
524-
"tough-cookie": {
525-
"maintainers": ["awaterma", "colincasey", "ruoho", "wjharney"]
526-
},
527446
"uglify-js": {
528447
"prefix": "v",
529448
"flaky": ["ppc", "darwin"],
530449
"maintainers": "mishoo",
531450
"skip": ["12", true],
532451
"comment": "Tests timeout"
533452
},
534-
"underscore": {
535-
"flaky": ["aix", "s390"],
536-
"skip": "win32",
537-
"maintainers": "jashkenas",
538-
"ignoreGitHead": true
539-
},
540-
"undici": {
541-
"prefix": "v",
542-
"maintainers": ["mcollina", "ronag"]
543-
},
544453
"uuid": {
545454
"prefix": "v",
546455
"maintainers": ["ctavan", "broofa"],
@@ -568,13 +477,10 @@
568477
"maintainers": "tootallnate",
569478
"tags": "native"
570479
},
571-
"winston": {
572-
"flaky": ["win32", "ppc", "s390", "darwin"],
573-
"maintainers": "indexzero"
574-
},
575480
"ws": {
576481
"expectFail": "fips",
577-
"maintainers": ["einaros", "3rd-Eden", "lpinca"]
482+
"maintainers": ["einaros", "3rd-Eden", "lpinca"],
483+
"scripts": ["test -- --timeout 30000"]
578484
},
579485
"yargs": {
580486
"comment": "Install from source is currently broken due to TS error",

lib/package-manager/test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ export async function test(packageManager, context) {
7676
scripts = context.module.scripts.map((script) => [
7777
packageManagerBin,
7878
'run',
79-
script
79+
...script.split(' ')
8080
]);
8181
} else {
8282
scripts = [[packageManagerBin, 'test']];

test/test-lookup.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,7 @@ test('lookup[getLookupTable]:', (t) => {
6565
});
6666
t.ok(table, 'table should exist');
6767
t.ok(table.lodash, 'lodash should be in the table');
68-
t.ok(
69-
table.underscore.maintainers,
70-
'underscore should contain a maintainers parameter'
71-
);
68+
t.ok(table.weak.maintainers, 'weak should contain a maintainers parameter');
7269
t.end();
7370
});
7471

0 commit comments

Comments
 (0)