Skip to content

Commit f15c9a2

Browse files
authored
lookup: removing modules that fail on Jenkins CI(#959)
We need to be able to trust that a failed CITGM run is something that needs to be investigated.
1 parent 5ed8640 commit f15c9a2

File tree

3 files changed

+16
-62
lines changed

3 files changed

+16
-62
lines changed

lib/lookup.json

Lines changed: 14 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,6 @@
5555
"prefix": "v",
5656
"skip": ["win32", "aix"]
5757
},
58-
"bluebird": {
59-
"prefix": "v",
60-
"maintainers": "petkaantonov"
61-
},
6258
"body-parser": {
6359
"flaky": "aix",
6460
"maintainers": "dougwilson"
@@ -90,7 +86,7 @@
9086
"maintainers": "mcollina",
9187
"flaky": ["rhel"],
9288
"prefix": "v",
93-
"skip": ["aix", "win32"]
89+
"skip": ["aix", "darwin", "win32"]
9490
},
9591
"coffeescript": {
9692
"maintainers": ["jashkenas", "GeoffreyBooth"],
@@ -153,19 +149,10 @@
153149
"expectFail": "fips",
154150
"skip": ["win32"]
155151
},
156-
"express": {
157-
"flaky": "ppc",
158-
"maintainers": "dougwilson",
159-
"skip": "win32"
160-
},
161152
"express-session": {
162153
"prefix": "v",
163154
"maintainers": "dougwilson"
164155
},
165-
"fastify": {
166-
"maintainers": ["mcollina", "delvedor"],
167-
"prefix": "v"
168-
},
169156
"flush-write-stream": {
170157
"prefix": "v",
171158
"maintainers": "mafintosh",
@@ -214,10 +201,6 @@
214201
"maintainers": "contra",
215202
"skip": "win32"
216203
},
217-
"https-proxy-agent": {
218-
"maintainers": "TooTallNate",
219-
"scripts": ["build", "test"]
220-
},
221204
"iconv": {
222205
"prefix": "v",
223206
"flaky": "aix",
@@ -235,6 +218,7 @@
235218
},
236219
"is-core-module": {
237220
"prefix": "v",
221+
"skip": "win32",
238222
"maintainers": "ljharb",
239223
"scripts": ["tests-only"]
240224
},
@@ -310,11 +294,13 @@
310294
},
311295
"mime": {
312296
"prefix": "v",
313-
"maintainers": "broofa"
297+
"maintainers": "broofa",
298+
"skip": "win32"
314299
},
315300
"minimist": {
316301
"npm": true,
317-
"maintainers": "substack"
302+
"skip": "win32",
303+
"maintainers": "ljharb"
318304
},
319305
"mkdirp": {
320306
"head": true,
@@ -358,11 +344,6 @@
358344
"comment": "Flaky because of test timeouts",
359345
"skip": true
360346
},
361-
"npm": {
362-
"maintainers": ["nodejs/npm"],
363-
"prefix": "v",
364-
"skip": ["aix", "s390"]
365-
},
366347
"path-to-regexp": {
367348
"prefix": "v",
368349
"maintainers": "blakeembrey",
@@ -386,11 +367,6 @@
386367
"comment": "Error message changes in V8 9.3",
387368
"repo": "https://github.com/pugjs/pug"
388369
},
389-
"pump": {
390-
"prefix": "v",
391-
"maintainers": "mafintosh",
392-
"skip": "win32"
393-
},
394370
"pumpify": {
395371
"prefix": "v",
396372
"maintainers": "mafintosh",
@@ -426,17 +402,8 @@
426402
},
427403
"rewire": {
428404
"prefix": "v",
429-
"maintainers": "jhnns"
430-
},
431-
"rimraf": {
432-
"prefix": "v",
433-
"flaky": "win32",
434-
"maintainers": "isaacs"
435-
},
436-
"router": {
437-
"prefix": "v",
438-
"maintainers": "dougwilson",
439-
"skip": "win32"
405+
"maintainers": "jhnns",
406+
"scripts": ["test -- --timeout 30000"]
440407
},
441408
"sax": {
442409
"skip": "win32",
@@ -454,10 +421,8 @@
454421
},
455422
"serialport": {
456423
"prefix": "serialport@",
457-
"flaky": ["ppc", "rhel"],
458424
"tags": "native",
459-
"maintainers": "reconbot",
460-
"skip": ["win32"]
425+
"maintainers": "reconbot"
461426
},
462427
"socket.io": {
463428
"maintainers": "rauchg",
@@ -497,7 +462,9 @@
497462
"tape": {
498463
"head": true,
499464
"prefix": "v",
500-
"maintainers": "substack"
465+
"skip": "win32",
466+
"scripts": ["tests-only"],
467+
"maintainers": "ljharb"
501468
},
502469
"thread-sleep": {
503470
"install": ["install", "--build-from-source"],
@@ -521,9 +488,6 @@
521488
"prefix": "v",
522489
"maintainers": "mafintosh"
523490
},
524-
"tough-cookie": {
525-
"maintainers": ["awaterma", "colincasey", "ruoho", "wjharney"]
526-
},
527491
"uglify-js": {
528492
"prefix": "v",
529493
"flaky": ["ppc", "darwin"],
@@ -537,10 +501,6 @@
537501
"maintainers": "jashkenas",
538502
"ignoreGitHead": true
539503
},
540-
"undici": {
541-
"prefix": "v",
542-
"maintainers": ["mcollina", "ronag"]
543-
},
544504
"uuid": {
545505
"prefix": "v",
546506
"maintainers": ["ctavan", "broofa"],
@@ -568,13 +528,10 @@
568528
"maintainers": "tootallnate",
569529
"tags": "native"
570530
},
571-
"winston": {
572-
"flaky": ["win32", "ppc", "s390", "darwin"],
573-
"maintainers": "indexzero"
574-
},
575531
"ws": {
576532
"expectFail": "fips",
577-
"maintainers": ["einaros", "3rd-Eden", "lpinca"]
533+
"maintainers": ["einaros", "3rd-Eden", "lpinca"],
534+
"scripts": ["test -- --timeout 30000"]
578535
},
579536
"yargs": {
580537
"comment": "Install from source is currently broken due to TS error",

lib/package-manager/test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ export async function test(packageManager, context) {
7676
scripts = context.module.scripts.map((script) => [
7777
packageManagerBin,
7878
'run',
79-
script
79+
...script.split(' ')
8080
]);
8181
} else {
8282
scripts = [[packageManagerBin, 'test']];

test/test-lookup.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,7 @@ test('lookup[getLookupTable]:', (t) => {
6565
});
6666
t.ok(table, 'table should exist');
6767
t.ok(table.lodash, 'lodash should be in the table');
68-
t.ok(
69-
table.underscore.maintainers,
70-
'underscore should contain a maintainers parameter'
71-
);
68+
t.ok(table.weak.maintainers, 'weak should contain a maintainers parameter');
7269
t.end();
7370
});
7471

0 commit comments

Comments
 (0)