test: store nocks in a sqlite database (#374)

* test: store nocks in a sqlite3 database

* chore: remove nock files

* refactor: reuse statement

* Update tests/recordRequests.js

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

* refactor: only create statements when needed

* refactor: move nocks db up one level

* fix: close db on exit

---------

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

Author: merceyz

.github/workflows/update-nock-files.yml

@@ -23,9 +23,7 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v4
         with:
-          # Let's use the oldest version supported to be sure the V8
-          # serialization is compatible with all supported versions.
-          node-version: 18.x
+          node-version: lts/*
 
       - name: Get the Yarn cache directory path
         id: yarn-cache-dir-path
@@ -43,21 +41,21 @@ jobs:
       - run: corepack yarn build # We need the stubs to run the tests
 
       - name: Remove old Nock files to avoid conflicts
-        run: rm -r tests/nock
+        run: rm tests/nocks.db
 
       - run: corepack yarn test
         env:
           NOCK_ENV: record
 
       - name: Check if anything has changed
         id: contains-changes
-        run: echo "result=$(git --no-pager diff --quiet -- tests/nock || echo "yes")" >> $GITHUB_OUTPUT
+        run: echo "result=$(git --no-pager diff --quiet -- tests/nocks.db || echo "yes")" >> $GITHUB_OUTPUT
         shell: bash
 
       - name: Commit changes
         if: ${{ steps.contains-changes.outputs.result == 'yes' }}
         run: |
-          git add tests/nock/
+          git add tests/nocks.db
           git config --global user.email "actions@github.com"
           git config --global user.name "GitHub Actions"
           git commit -m "update Nock files"
@@ -72,10 +70,10 @@ jobs:
         env:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
-      - name: Upload `tests/nock` in case of failure
+      - name: Upload `tests/nocks.db` in case of failure
         uses: actions/upload-artifact@v4
         if: ${{ failure() && steps.contains-changes.outputs.result == 'yes' }}
         with:
           name: nock
           path: |
-            tests/nock
+            tests/nocks.db

package.json

@@ -35,6 +35,7 @@
     "@yarnpkg/fslib": "^3.0.0-rc.48",
     "@zkochan/cmd-shim": "^6.0.0",
     "babel-plugin-dynamic-import-node": "^2.3.3",
+    "better-sqlite3": "^9.4.1",
     "clipanion": "^3.0.1",
     "debug": "^4.1.1",
     "esbuild": "0.19.5",

tests/_runCli.ts

@@ -6,8 +6,6 @@ export async function runCli(cwd: PortablePath, argv: Array<string>): Promise<{e
   const err: Array<Buffer> = [];
 
   return new Promise((resolve, reject) => {
-    if (process.env.RUN_CLI_ID)
-      (process.env.RUN_CLI_ID as any)++;
     const child = spawn(process.execPath, [`--no-warnings`, `-r`, require.resolve(`./recordRequests.js`), require.resolve(`../dist/corepack.js`), ...argv], {
       cwd: npath.fromPortablePath(cwd),
       env: process.env,