Change the check for 1xx status code

azaretsky · azaretsky · commit c70bd2187cec · 2019-05-04T17:36:45.000+03:00
"status_code &gt;= 100 &amp;&amp; status_code &lt; 200" might be faster than
"status_code / 100 == 1"
diff --git a/http_parser.c b/http_parser.c
@@ -886,10 +886,11 @@ size_t http_parser_execute (http_parser *parser,
       case s_res_status_start:
       {
         /* See RFC 7230 section 3.3.3, step 1 */
-        if (parser->status_code / 100 == 1 || /* 1xx e.g. Continue */
+        if ((parser->status_code >= 100 &&
+             parser->status_code < 200) ||    /* 1xx e.g. Continue */
             parser->status_code == 204 ||     /* No Content */
             parser->status_code == 304) {     /* Not Modified */
-            parser->flags |= F_SKIPBODY;
+          parser->flags |= F_SKIPBODY;
         }
         MARK(status);
         UPDATE_STATE(s_res_status);

Original file line number	Diff line number	Diff line change
`@@ -886,10 +886,11 @@ size_t http_parser_execute (http_parser *parser,`
`886`	`886`	`case s_res_status_start:`
`887`	`887`	`{`
`888`	`888`	`/* See RFC 7230 section 3.3.3, step 1 */`
`889`		`- if (parser->status_code / 100 == 1 \|\| /* 1xx e.g. Continue */`
	`889`	`+ if ((parser->status_code >= 100 &&`
	`890`	`+ parser->status_code < 200) \|\| /* 1xx e.g. Continue */`
`890`	`891`	`parser->status_code == 204 \|\| /* No Content */`
`891`	`892`	`parser->status_code == 304) { /* Not Modified */`
`892`		`- parser->flags \|= F_SKIPBODY;`
	`893`	`+ parser->flags \|= F_SKIPBODY;`
`893`	`894`	`}`
`894`	`895`	`MARK(status);`
`895`	`896`	`UPDATE_STATE(s_res_status);`