Skip to content

Commit 3912ebe

Browse files
committed
fixup! src: move JSDate "ToString" logic to JSDate class
1 parent f07151d commit 3912ebe

3 files changed

Lines changed: 4 additions & 18 deletions

File tree

src/llv8-inl.h

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -279,18 +279,6 @@ ACCESSOR(JSRegExp, GetSource, js_regexp()->kSourceOffset, String)
279279

280280
ACCESSOR(JSDate, GetValue, js_date()->kValueOffset, Value)
281281

282-
bool JSDate::IsSmi(Error& err) {
283-
v8::Value val(GetValue(err));
284-
v8::Smi smi(val);
285-
return smi.Check();
286-
}
287-
288-
bool JSDate::IsHeapNumber(Error& err) {
289-
v8::Value val(GetValue(err));
290-
v8::HeapNumber heap_number(val);
291-
return heap_number.Check();
292-
}
293-
294282
bool String::IsString(LLV8* v8, HeapObject heap_object, Error& err) {
295283
if (!heap_object.Check()) return false;
296284

src/llv8.cc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -684,17 +684,17 @@ std::string JSDate::ToString(Error& err) {
684684

685685
// Check if it is SMI
686686
// e.g: date = new Date(1)
687-
if (IsSmi(err)) {
688-
v8::Smi smi(val);
687+
v8::Smi smi(val);
688+
if (smi.Check()) {
689689
std::string s = smi.ToString(err);
690690
if (err.Fail()) return "";
691691
return s;
692692
}
693693

694694
// Check if it is HeapNumber
695695
// e.g: date = new Date()
696-
if (IsHeapNumber(err)) {
697-
v8::HeapNumber hn(val);
696+
v8::HeapNumber hn(val);
697+
if (hn.Check()) {
698698
std::string s = hn.ToString(true, err);
699699
if (err.Fail()) return "";
700700
return s;

src/llv8.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -373,8 +373,6 @@ class JSDate : public JSObject {
373373
V8_VALUE_DEFAULT_METHODS(JSDate, JSObject);
374374

375375
inline Value GetValue(Error& err);
376-
inline bool IsSmi(Error& err);
377-
inline bool IsHeapNumber(Error& err);
378376
std::string ToString(Error& err);
379377
};
380378

0 commit comments

Comments
 (0)