Skip to content

Commit 4b33125

Browse files
committed
chore(ci): fix CI by disabling nightly builds
1 parent 279a540 commit 4b33125

File tree

1 file changed

+19
-13
lines changed

1 file changed

+19
-13
lines changed

.github/workflows/push.yml

Lines changed: 19 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -19,38 +19,43 @@ jobs:
1919
- version: 10.x
2020
- version: 12.x
2121
- version: 14.x
22-
- version: 15.x
23-
mirror: https://nodejs.org/download/nightly
24-
- version: 15.x
25-
mirror: https://nodejs.org/download/v8-canary
22+
# TODO(mmarchini): re-enable once mirror is supported on setup-node
23+
# - version: 15.x
24+
# mirror: https://nodejs.org/download/nightly
25+
# - version: 15.x
26+
# mirror: https://nodejs.org/download/v8-canary
2627
# os: [ubuntu-latest, macos-latest]
2728
# Temporarily disable MacOS until
2829
# https://github.com/nodejs/node/issues/32981 is fixed
29-
os: [ubuntu-latest]
30+
# TODO(mmarchini): test on 20.04 (need different lldb version)
31+
os: [ubuntu-18.04, ubuntu-20.04]
32+
llvm: [ '6.0', 7, 8 ]
3033
steps:
3134
- uses: actions/checkout@v1
3235
- name: Use Node.js ${{ matrix.node.version }} ${{ matrix.node.mirror }}
33-
uses: mmarchini/setup-node@mirror
36+
uses: actions/setup-node@v2
3437
with:
3538
node-version: ${{ matrix.node.version }}
36-
node-mirror: ${{ matrix.node.mirror }}
39+
# TODO(mmarchini): re-enable once mirror is supported on setup-node
40+
# node-mirror: ${{ matrix.node.mirror }}
3741
- name: install dependencies Linux
38-
if: matrix.os == 'ubuntu-latest'
42+
if: startsWith(matrix.os, 'ubuntu-')
3943
run: |
4044
sudo apt-get -qq update
41-
sudo apt-get install lldb-3.9 liblldb-3.9-dev lcov gdb -y
45+
sudo apt-get install lldb-${{ matrix.llvm }} liblldb-${{ matrix.llvm }}-dev lcov gdb -y
46+
sudo ln -s $(which lldb-${{ matrix.llvm }}) /usr/bin/lldb
4247
- name: npm install
4348
run: |
4449
npm install --llnode_build_addon=true --llnode_coverage=true
4550
- name: run tests
46-
run: TEST_LLDB_BINARY=`which lldb-3.9` npm run nyc-test-all
51+
run: TEST_LLDB_BINARY=`which lldb-${{ matrix.llvm }}` npm run nyc-test-all
4752
if: matrix.node.version != '15.x'
4853
- name: run tests (nightly)
49-
run: TEST_LLDB_BINARY=`which lldb-3.9` npm run nyc-test-all
54+
run: TEST_LLDB_BINARY=`which lldb-${{ matrix.llvm }}` npm run nyc-test-all
5055
if: matrix.node.version == '15.x'
5156
continue-on-error: true
5257
- name: prepare coverage
53-
if: matrix.os == 'ubuntu-latest' && matrix.node.version != '15.x'
58+
if: startsWith(matrix.os, 'ubuntu-') && matrix.node.version != '15.x'
5459
run: |
5560
npm run coverage
5661
cat ./coverage-js.info > ./coverage.info
@@ -70,6 +75,7 @@ jobs:
7075
- name: npm install, build, and test
7176
run: |
7277
sudo apt-get -qq update
73-
sudo apt-get install lldb-3.9 liblldb-3.9-dev lcov -y
78+
sudo apt-get install lldb-6.0 liblldb-6.0-dev lcov -y
79+
sudo ln -s $(which lldb-6.0) /usr/bin/lldb
7480
npm install
7581
npm run linter

0 commit comments

Comments
 (0)