Add command line support on Windows

This change adds the command line to NodeReport on Windows. It
uses the Windows GetCommandLine() API to obtain the command line.

Also includes a minor change to print "Command line:" rather than
"Command line arguments:" in the report as prefix, plus updates to
the testcases.

Author: rnchamberlain

src/node_report.cc

@@ -364,7 +364,9 @@ void SetCommandLine() {
       separator = " ";
     }
   }
-#endif // _AIX
+#elif _WIN32
+  commandline_string = GetCommandLine();
+#endif
 }
 
 /*******************************************************************************
@@ -541,7 +543,7 @@ void TriggerNodeReport(Isolate* isolate, DumpEvent event, const char* message, c
  ******************************************************************************/
 static void PrintCommandLine(FILE* fp) {
   if (commandline_string != "") {
-    fprintf(fp, "Command line arguments: %s\n", commandline_string.c_str());
+    fprintf(fp, "Command line: %s\n", commandline_string.c_str());
   }
 }
 

test/common.js

@@ -45,7 +45,7 @@ exports.validate = (t, report, options) => {
                 'Checking report contains ' + section + ' section');
       });
 
-      // Check NodeReport section
+      // Check NodeReport header section
       const nodeReportSection = getSection(reportContents, 'NodeReport');
       t.contains(nodeReportSection, new RegExp('Process ID: ' + pid),
               'NodeReport section contains expected process ID');
@@ -58,8 +58,17 @@ exports.validate = (t, report, options) => {
                 'NodeReport section contains expected Node.js version');
       }
       if (options && options.commandline) {
-        t.match(nodeReportSection, new RegExp('Command line arguments: ' + options.commandline),
-                'NodeReport section contains expected command line');
+        if (this.isWindows()) {
+          // On Windows we need to strip out double quotes from the command line in the
+          // report, and escape the backslashes in the regex comparison string.
+          t.match(nodeReportSection.replace(/"/g,''),
+                  new RegExp('Command line: ' + (options.commandline).replace(/\\/g,'\\\\')),
+                  'Checking report contains expected command line');
+        } else {
+          t.match(nodeReportSection,
+                  new RegExp('Command line: ' + options.commandline),
+                  'Checking report contains expected command line');
+        }
       }
       nodeComponents.forEach((c) => {
         if (c !== 'node') {