fix: eliminate for ... of syntax

Author: himself65

lib/_http_outgoing.js

@@ -288,7 +288,8 @@ OutgoingMessage.prototype.uncork = function uncork() {
     }
   }
   this._send(crlf_buf, null, callbacks.length ? (err) => {
-    for (const callback of callbacks) {
+    for (let i = 0; i < callbacks.length; i++) {
+      const callback = callbacks[i];
       callback(err);
     }
   } : null);
@@ -675,7 +676,8 @@ OutgoingMessage.prototype.setHeaders = function setHeaders(headers) {
   // set-cookie values in array and set them all at once.
   const cookies = [];
 
-  for (const { 0: key, 1: value } of headers) {
+  for (let i = 0; i < headers.length; i++) {
+    const { 0: key, 1: value } = headers[i];
     if (key === 'set-cookie') {
       if (ArrayIsArray(value)) {
         cookies.push(...value);

lib/_http_server.js

@@ -330,7 +330,9 @@ ServerResponse.prototype.writeEarlyHints = function writeEarlyHints(hints, cb) {
 
   head += 'Link: ' + link + '\r\n';
 
-  for (const key of ObjectKeys(hints)) {
+  const hintKeys = ObjectKeys(hints);
+  for (let i = 0; i < hintKeys.length; i++) {
+    const key = hintKeys[i];
     if (key !== 'link') {
       head += key + ': ' + hints[key] + '\r\n';
     }

lib/assert.js

@@ -350,7 +350,8 @@ assert.partialDeepStrictEqual = function partialDeepStrictEqual(
 
 class Comparison {
   constructor(obj, keys, actual) {
-    for (const key of keys) {
+    for (let i = 0; i < keys.length; i++) {
+      const key = keys[i];
       if (key in obj) {
         if (actual !== undefined &&
             typeof actual[key] === 'string' &&
@@ -433,7 +434,8 @@ function expectedException(actual, expected, message, fn) {
                                         expected, 'may not be an empty object');
       }
       if (isDeepEqual === undefined) lazyLoadComparison();
-      for (const key of keys) {
+      for (let i = 0; i < keys.length; i++) {
+        const key = keys[i];
         if (typeof actual[key] === 'string' &&
             isRegExp(expected[key]) &&
             RegExpPrototypeExec(expected[key], actual[key]) !== null) {
@@ -722,7 +724,8 @@ assert.ifError = function ifError(err) {
         );
         // Filter all frames existing in err.stack.
         let newFrames = StringPrototypeSplit(newErr.stack, '\n');
-        for (const errFrame of originalFrames) {
+        for (let i = 0; i < originalFrames.length; i++) {
+          const errFrame = originalFrames[i];
           // Find the first occurrence of the frame.
           const pos = ArrayPrototypeIndexOf(newFrames, errFrame);
           if (pos !== -1) {

lib/child_process.js

@@ -554,8 +554,10 @@ function copyPermissionModelFlagsToEnv(env, key, args) {
   }
 
   const flagsToCopy = getPermissionModelFlagsToCopy();
-  for (const arg of process.execArgv) {
-    for (const flag of flagsToCopy) {
+  for (let i = 0; i < process.execArgv.length; i++) {
+    const arg = process.execArgv[i];
+    for (let j = 0; j < flagsToCopy.length; j++) {
+      const flag = flagsToCopy[j];
       if (arg.startsWith(flag)) {
         env[key] = `${env[key] ? env[key] + ' ' + arg : arg}`;
       }
@@ -727,7 +729,8 @@ function normalizeSpawnArguments(file, args, options) {
     );
   }
 
-  for (const key of envKeys) {
+  for (let i = 0; i < envKeys.length; i++) {
+    const key = envKeys[i];
     const value = env[key];
     if (value !== undefined) {
       validateArgumentNullCheck(key, `options.env['${key}']`);

lib/dgram.js

@@ -591,8 +591,10 @@ function clearQueue() {
   state.queue = undefined;
 
   // Flush the send queue.
-  for (const queueEntry of queue)
+  for (let i = 0; i < queue.length; i++) {
+    const queueEntry = queue[i];
     queueEntry();
+  }
 }
 
 // valid combinations

lib/diagnostics_channel.js

@@ -1,6 +1,7 @@
 'use strict';
 
 const {
+  ArrayFrom,
   ArrayPrototypeAt,
   ArrayPrototypeIndexOf,
   ArrayPrototypePush,
@@ -162,7 +163,9 @@ class ActiveChannel {
       return ReflectApply(fn, thisArg, args);
     };
 
-    for (const entry of this._stores.entries()) {
+    const storeEntries = ArrayFrom(this._stores.entries());
+    for (let i = 0; i < storeEntries.length; i++) {
+      const entry = storeEntries[i];
       const store = entry[0];
       const transform = entry[1];
       run = wrapStoreRun(store, data, run, transform);

lib/events.js

@@ -751,7 +751,9 @@ EventEmitter.prototype.removeAllListeners =
 
       // Emit removeListener for all listeners on all events
       if (arguments.length === 0) {
-        for (const key of ReflectOwnKeys(events)) {
+        const eventKeys = ReflectOwnKeys(events);
+        for (let i = 0; i < eventKeys.length; i++) {
+          const key = eventKeys[i];
           if (key === 'removeListener') continue;
           this.removeAllListeners(key);
         }

lib/inspector.js

@@ -1,6 +1,7 @@
 'use strict';
 
 const {
+  ArrayFrom,
   JSONParse,
   JSONStringify,
   SafeMap,
@@ -150,8 +151,9 @@ class Session extends EventEmitter {
       return;
     this.#connection.disconnect();
     this.#connection = null;
-    const remainingCallbacks = this.#messageCallbacks.values();
-    for (const callback of remainingCallbacks) {
+    const remainingCallbacks = ArrayFrom(this.#messageCallbacks.values());
+    for (let i = 0; i < remainingCallbacks.length; i++) {
+      const callback = remainingCallbacks[i];
       process.nextTick(callback, new ERR_INSPECTOR_CLOSED());
     }
     this.#messageCallbacks.clear();

lib/internal/abort_controller.js

@@ -4,6 +4,7 @@
 // in https://github.com/mysticatea/abort-controller (MIT license)
 
 const {
+  ArrayFrom,
   ArrayPrototypePush,
   ObjectAssign,
   ObjectDefineProperties,
@@ -296,7 +297,9 @@ class AbortSignal extends EventTarget {
       } else if (!signal[kSourceSignals]) {
         continue;
       } else {
-        for (const sourceSignalWeakRef of signal[kSourceSignals]) {
+        const sourceSignalWeakRefs = ArrayFrom(signal[kSourceSignals]);
+        for (let i = 0; i < sourceSignalWeakRefs.length; i++) {
+          const sourceSignalWeakRef = sourceSignalWeakRefs[i];
           const sourceSignal = sourceSignalWeakRef.deref();
           if (!sourceSignal) {
             continue;

lib/internal/assert/utils.js

@@ -1,6 +1,7 @@
 'use strict';
 
 const {
+  ArrayFrom,
   ArrayPrototypeShift,
   Error,
   ErrorCaptureStackTrace,
@@ -126,7 +127,9 @@ function parseCode(code, offset) {
   let node;
   let start;
   // Parse the read code until the correct expression is found.
-  for (const token of tokenizer(code, { ecmaVersion: 'latest' })) {
+  const tokens = ArrayFrom(tokenizer(code, { ecmaVersion: 'latest' }));
+  for (let i = 0; i < tokens.length; i++) {
+    const token = tokens[i];
     start = token.start;
     if (start > offset) {
       // No matching expression found. This could happen if the assert
@@ -222,7 +225,8 @@ function getErrMessage(message, fn) {
       }
       const frames = StringPrototypeSplit(message, '\n');
       message = ArrayPrototypeShift(frames);
-      for (const frame of frames) {
+      for (let i = 0; i < frames.length; i++) {
+        const frame = frames[i];
         let pos = 0;
         while (pos < column && (frame[pos] === ' ' || frame[pos] === '\t')) {
           pos++;